Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Issue 1474543002: Makes NewWindow() take set of properties for window (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes NewWindow() take set of properties for window This way the WM can correctly see the set of properties during creation and we don't need a bunch of round trips for setting individual properties. BUG=548424 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/167ac0ed89d559162be1ba08c08abc7123c34748 Cr-Commit-Position: refs/heads/master@{#361242}

Patch Set 1 #

Patch Set 2 : nuke shadow_style changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -39 lines) Patch
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/mus/public/cpp/window_tree_connection.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 2 chunks +2 lines, -3 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 chunk +3 lines, -4 lines 0 comments Download
M components/mus/ws/connection_manager.h View 2 chunks +4 lines, -1 line 0 comments Download
M components/mus/ws/connection_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/mus/ws/server_window.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/mus/ws/server_window.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_impl.h View 2 chunks +6 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M mash/wm/window_manager_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/wm/window_manager_impl.cc View 1 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
5 years, 1 month ago (2015-11-23 23:01:47 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-23 23:16:05 UTC) #2
sky
I nuked the shadow changes and kept this at providing properties during creation.
5 years, 1 month ago (2015-11-24 00:10:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474543002/20001
5 years, 1 month ago (2015-11-24 00:11:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-24 03:16:16 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 03:17:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/167ac0ed89d559162be1ba08c08abc7123c34748
Cr-Commit-Position: refs/heads/master@{#361242}

Powered by Google App Engine
This is Rietveld 408576698