Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474533004: Merge the DateTimeSuggestionBuilder in to the file that uses it (Closed)

Created:
5 years ago by Peter Beverloo
Modified:
5 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge the DateTimeSuggestionBuilder in to the file that uses it It's one very trivial function that only has a single call-site. It doesn't need its own file. BUG= Committed: https://crrev.com/7c9159b5b7a8b9676badd1b93cf2cf3bc78fdf47 Cr-Commit-Position: refs/heads/master@{#361357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -49 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/android/renderer_date_time_picker.cc View 2 chunks +17 lines, -2 lines 0 comments Download
D content/renderer/date_time_suggestion_builder.h View 1 chunk +0 lines, -23 lines 0 comments Download
D content/renderer/date_time_suggestion_builder.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Beverloo
5 years ago (2015-11-24 11:43:26 UTC) #2
Avi (use Gerrit)
This was really a thing?! LGTM
5 years ago (2015-11-24 16:09:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474533004/1
5 years ago (2015-11-24 16:11:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 16:25:47 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 16:27:12 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7c9159b5b7a8b9676badd1b93cf2cf3bc78fdf47
Cr-Commit-Position: refs/heads/master@{#361357}

Powered by Google App Engine
This is Rietveld 408576698