update web_components

pkg/polymer/test/run.sh

Index: pkg/polymer/test/run.sh
diff --git a/pkg/polymer/test/run.sh b/pkg/polymer/test/run.sh
index 62497be890cd08bb775151a3e1b6fb3d2e6265ca..0f7859f3912373c7bfed98b7e37af104db026765 100755
--- a/pkg/polymer/test/run.sh
+++ b/pkg/polymer/test/run.sh
@@ -14,17 +14,21 @@ pushd $DIR/../../.. > /dev/null
 
 echo "*** Running unit tests for Polymer.dart and its dependencies."
 
-SUITES="pkg/polymer samples/third_party/todomvc"
-
-ANALYZER_CONFIG="-m release -r none -c dartanalyzer $*"
-CONFIG="-m release -r vm,drt,ff,chrome,d8,jsshell -c none,dart2js --checked $*"
-
-CMD="./tools/test.py $ANALYZER_CONFIG $SUITES"
-echo "*** $CMD"
-$CMD
-
-CMD="xvfb-run ./tools/test.py $CONFIG $SUITES"
-echo "*** $CMD"
-$CMD
+# Note: you can't combine two different pkg/ selectors in the same command.
+# Also, test.py gets less happy the more tests that are run.
+# So we run all of the filters separately.
+for SUITES in pkg/observe html/custom pkg/template_binding pkg/polymer samples/third_party/todomvc

[blois, 2014/02/12 02:29:31]

line length

[blois, 2014/02/12 02:29:31]

for loop variables (SUITES) should be lower_cased.

+do
+  ANALYZER_CONFIG="-m release -r none -c dartanalyzer $*"

[blois, 2014/02/12 02:29:31]

should use readonly:
readonly ANALYZER_CONFIG="-m release -r none -c dartanalyzer $*"

+  CONFIG="-m release -r vm,drt,ff,chrome,d8,jsshell -c none,dart2js --checked $*"
+
+  CMD="./tools/test.py $ANALYZER_CONFIG $SUITES"

[blois, 2014/02/12 02:29:31]

should expand variables using:
${ANALYZER}

[blois, 2014/02/12 02:29:31]

CMD is being assigned to multiple times, should not be in caps.

+  echo "*** $CMD"
+  $CMD
+
+  CMD="xvfb-run ./tools/test.py $CONFIG $SUITES"
+  echo "*** $CMD"
+  $CMD
+done
 
 echo -e "All tests pass"