Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1474513004: [MD settings] adding more sections to the settings menu (Closed)

Created:
5 years, 1 month ago by dschuyler
Modified:
5 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] adding more sections to the settings menu This adds several settings menu entries for sections that were added without menu entries. BUG=425627 Committed: https://crrev.com/04b1c397117e843cc6ec50c2182d51be23940313 Cr-Commit-Position: refs/heads/master@{#361396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 5 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
5 years, 1 month ago (2015-11-24 02:02:42 UTC) #3
stevenjb
lgtm
5 years ago (2015-11-24 17:55:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474513004/1
5 years ago (2015-11-24 18:28:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:37:43 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 18:39:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04b1c397117e843cc6ec50c2182d51be23940313
Cr-Commit-Position: refs/heads/master@{#361396}

Powered by Google App Engine
This is Rietveld 408576698