android_webview/native/BUILD.gn - Issue 1474483004: WebView Metrics client implementation (Chromium part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/BUILD.gn

Issue 1474483004: WebView Metrics client implementation (Chromium part) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwMetricsServiceClient.java ('K') | « android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java ('k') | android_webview/native/android_webview_jni_registrar.cc » ('j') | android_webview/native/webview_native.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/BUILD.gn

diff --git a/android_webview/native/BUILD.gn b/android_webview/native/BUILD.gn

index cec2c0ecbb9b1002f95052da6d9afa1a271374f1..c4dbb20ba188b8328a58a8c8cfb123554970358d 100644

--- a/android_webview/native/BUILD.gn

+++ b/android_webview/native/BUILD.gn

@@ -28,7 +28,10 @@ source_set("native") {

"//ui/gfx/geometry:geometry",

]

- include_dirs = [ "//skia/config" ]

+ include_dirs = [

+ "//skia/config",

+ "//third_party/protobuf",

sgurun-gerrit only 2015/12/11 00:06:46 should this be here?

paulmiller 2015/12/18 00:15:50 required by metrics_service_client.h; will investi

+ ]

sources = [

"android_protocol_handler.cc",

@@ -65,6 +68,8 @@ source_set("native") {

"aw_media_url_interceptor.h",

"aw_message_port_service_impl.cc",

"aw_message_port_service_impl.h",

+ "aw_metrics_switch.cc",

+ "aw_metrics_switch.h",

"aw_pdf_exporter.cc",

"aw_pdf_exporter.h",

"aw_picture.cc",

@@ -128,6 +133,7 @@ generate_jni("native_jni") {

"../java/src/org/chromium/android_webview/AwFormDatabase.java",

"../java/src/org/chromium/android_webview/AwHttpAuthHandler.java",

"../java/src/org/chromium/android_webview/AwMessagePortService.java",

+ "../java/src/org/chromium/android_webview/AwMetricsServiceClient.java",

"../java/src/org/chromium/android_webview/AwPdfExporter.java",

"../java/src/org/chromium/android_webview/AwPicture.java",

"../java/src/org/chromium/android_webview/AwQuotaManagerBridge.java",