android_webview/browser/aw_browser_main_parts.cc - Issue 1474483004: WebView Metrics client implementation (Chromium part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_browser_main_parts.cc

Issue 1474483004: WebView Metrics client implementation (Chromium part) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move client back to browser layer, make it a Leaky global, and some cleanup Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_browser_main_parts.h ('k') | android_webview/browser/aw_metrics_service_client.h » ('j') | android_webview/browser/aw_metrics_service_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_browser_main_parts.cc

diff --git a/android_webview/browser/aw_browser_main_parts.cc b/android_webview/browser/aw_browser_main_parts.cc

index 7bba3014781a3e5666b69b03558e3e3b63df95b2..6d22ac11fadc949e2182405504d7a97396fe94ab 100644

--- a/android_webview/browser/aw_browser_main_parts.cc

+++ b/android_webview/browser/aw_browser_main_parts.cc

@@ -99,6 +99,10 @@ void AwBrowserMainParts::PreMainMessageLoopRun() {

}

+void AwBrowserMainParts::PostMainMessageLoopRun() {

+ browser_context_->PostMainMessageLoopRun();

bool AwBrowserMainParts::MainMessageLoopRun(int* result_code) {

// Android WebView does not use default MessageLoop. It has its own

// Android specific MessageLoop.