WebView Metrics client implementation (Chromium part)

android_webview/browser/aw_metrics_service_client.cc

Index: android_webview/browser/aw_metrics_service_client.cc
diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..74de2f6b0d0049be3d5dabc59d8f7e46f58cdeed
--- /dev/null
+++ b/android_webview/browser/aw_metrics_service_client.cc
@@ -0,0 +1,172 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "android_webview/browser/aw_metrics_service_client.h"
+
+#include "android_webview/common/aw_version_info_values.h"
+#include "base/bind.h"
+#include "base/i18n/rtl.h"
+#include "base/prefs/pref_service.h"
+#include "components/metrics/metrics_service.h"
+#include "components/metrics/metrics_state_manager.h"
+#include "components/metrics/net/net_metrics_log_uploader.h"
+#include "components/metrics/ui/screen_info_metrics_provider.h"
+#include "components/metrics/url_constants.h"
+
+namespace android_webview {
+
+base::LazyInstance<AwMetricsServiceClient>::Leaky g_lazy_instance_;
+
+namespace {
+const int kUploadIntervalMinutes = 30;
+}

[sgurun-gerrit only, 2015/12/21 21:47:25]

nit: add // namespace to indicate the end of namespace 

[paulmiller, 2015/12/22 19:42:04]

done

+
+// static
+AwMetricsServiceClient* AwMetricsServiceClient::GetInstance() {
+  return g_lazy_instance_.Pointer();
+}
+
+// static
+void AwMetricsServiceClient::Initialize(
+    PrefService* pref_service,
+    net::URLRequestContextGetter* request_context) {
+  DCHECK(!is_initialized_);
+
+  pref_service_ = pref_service;
+  request_context_ = request_context;
+
+  metrics_state_manager_ = metrics::MetricsStateManager::Create(
+      pref_service_, base::Bind(&AwMetricsServiceClient::IsReportingEnabled,
+                                base::Unretained(this)),
+      base::Bind(&AwMetricsServiceClient::StoreClientInfo,
+                 base::Unretained(this)),
+      base::Bind(&AwMetricsServiceClient::LoadClientInfo,
+                 base::Unretained(this)));
+  metrics_service_.reset(new ::metrics::MetricsService(
+      metrics_state_manager_.get(), this, pref_service_));
+

[sgurun-gerrit only, 2015/12/21 21:47:25]

please file a bug that blocks main UMA bug to add other metrics service
providers.

[paulmiller, 2015/12/22 19:42:04]

I'll just copy all the relevant-looking ones from
ChromeMetricsServiceClient::Initialize. Except for AndroidMetricsProvider, since
that one's under chrome/. Maybe there should be a non-blocking bug to refactor
AndroidMetricsProvider into components/metrics/ ?

+  metrics_service_->RegisterMetricsProvider(
+      scoped_ptr<metrics::MetricsProvider>(
+          new metrics::ScreenInfoMetricsProvider));
+  metrics_service_->InitializeMetricsRecordingState();
+
+  is_initialized_ = true;
+
+  if (IsReportingEnabled())
+    metrics_service_->Start();
+}
+
+void AwMetricsServiceClient::Finalize() {
+  DCHECK(is_initialized_);
+  metrics_service_->Stop();
+}
+
+void AwMetricsServiceClient::SetMetricsEnabled(bool enabled) {
+  // If the client is already initialized, apply the setting immediately.
+  // Otherwise, it will be applied on initialization.
+  if (is_initialized_ && is_enabled_ != enabled) {
+    if (enabled) {

[sgurun-gerrit only, 2015/12/21 21:47:26]

nit: no brackets when if block is oneliner.

[paulmiller, 2015/12/22 19:42:04]

done

+      metrics_service_->Start();
+    } else {
+      metrics_service_->Stop();
+    }
+  }
+  is_enabled_ = enabled;
+}
+
+metrics::MetricsService* AwMetricsServiceClient::GetMetricsService() {
+  return metrics_service_.get();
+}
+
+// In Chrome, UMA and Breakpad are enabled/disabled together by the same
+// checkbox and they share the same client ID (a.k.a. GUID). SetMetricsClientId
+// and OnRecordingDisabled are intended to provide the ID to Breakpad. In
+// WebView, UMA and Breakpad are independent, so these are no-ops.
+
+void AwMetricsServiceClient::SetMetricsClientId(const std::string& client_id) {}
+
+void AwMetricsServiceClient::OnRecordingDisabled() {}
+
+bool AwMetricsServiceClient::IsOffTheRecordSessionActive() {
+  // WebView has no incognito mode.
+  return false;
+}
+
+int32_t AwMetricsServiceClient::GetProduct() {
+  // TODO(paulmiller) Switch this to a WebView product once we have a log source
+  // for WebView.

[sgurun-gerrit only, 2015/12/21 21:47:26]

this seems to need its own bug (or 564962 is satisfactory?)

[paulmiller, 2015/12/22 19:42:04]

The purpose of 564962 is to get the log source, so I think that's sufficient.

+  return ::metrics::ChromeUserMetricsExtension::CHROME;
+}
+
+std::string AwMetricsServiceClient::GetApplicationLocale() {
+  return base::i18n::GetConfiguredLocale();
+}
+
+bool AwMetricsServiceClient::GetBrand(std::string* brand_code) {
+  // WebView doesn't use brand codes.
+  return false;
+}
+
+metrics::SystemProfileProto::Channel AwMetricsServiceClient::GetChannel() {
+  // "Channel" means stable, beta, etc. WebView doesn't have channel info yet.
+  // TODO(paulmiller) Update this once we have channel info.
+  return metrics::SystemProfileProto::CHANNEL_UNKNOWN;
+}
+
+std::string AwMetricsServiceClient::GetVersionString() {
+  return PRODUCT_VERSION;
+}
+
+void AwMetricsServiceClient::OnLogUploadComplete() {}
+
+void AwMetricsServiceClient::InitializeSystemProfileMetrics(
+    const base::Closure& done_callback) {
+  done_callback.Run();
+}
+
+void AwMetricsServiceClient::CollectFinalMetricsForLog(
+    const base::Closure& done_callback) {
+  done_callback.Run();
+}
+
+scoped_ptr<metrics::MetricsLogUploader> AwMetricsServiceClient::CreateUploader(
+    const base::Callback<void(int)>& on_upload_complete) {
+  return scoped_ptr<::metrics::MetricsLogUploader>(
+      new metrics::NetMetricsLogUploader(
+          request_context_,
+          // TODO(paulmiller): Switch this to metrics::kDefaultMetricsServerUrl
+          // once we have a log source for WebView.
+          "http://localhost:10000/uma/v2",
+          metrics::kDefaultMetricsMimeType,
+          on_upload_complete));
+}
+
+base::TimeDelta AwMetricsServiceClient::GetStandardUploadInterval() {
+  return base::TimeDelta::FromMinutes(kUploadIntervalMinutes);
+}
+
+AwMetricsServiceClient::AwMetricsServiceClient()
+    : is_initialized_(false),
+      is_enabled_(false),
+      pref_service_(nullptr),
+      request_context_(nullptr) {}
+
+AwMetricsServiceClient::~AwMetricsServiceClient() {}
+
+bool AwMetricsServiceClient::IsReportingEnabled() {
+  return is_enabled_;

[sgurun-gerrit only, 2015/12/21 21:47:25]

this is called as a callback from metrics service. Add a
dcheck_currently_on(Browserthread::UI) here to ease catching any regressions,
since it is set from java side (in main thread)

[paulmiller, 2015/12/22 19:42:04]

done

+}
+
+// Store/LoadClientInfo allow Windows Chrome to back up ClientInfo. They're
+// no-ops for WebView.
+
+void AwMetricsServiceClient::StoreClientInfo(
+    const metrics::ClientInfo& client_info) {}
+
+scoped_ptr<metrics::ClientInfo> AwMetricsServiceClient::LoadClientInfo() {
+  scoped_ptr<metrics::ClientInfo> client_info;
+  return client_info.Pass();
+}
+
+}  // namespace android_webview