android_webview/android_webview.gyp - Issue 1474483004: WebView Metrics client implementation (Chromium part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/android_webview.gyp

Issue 1474483004: WebView Metrics client implementation (Chromium part) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments on address of comments from #5 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/android_webview.gyp

diff --git a/android_webview/android_webview.gyp b/android_webview/android_webview.gyp

index 6b9e7b06e270afd82422fead438e5e538d52d4b4..7c325c9d57180081df4583729c93bb867a267c12 100644

--- a/android_webview/android_webview.gyp

+++ b/android_webview/android_webview.gyp

@@ -230,6 +230,9 @@

'../components/components.gyp:crash_component',

'../components/components.gyp:data_reduction_proxy_core_browser',

'../components/components.gyp:devtools_discovery',

+ '../components/components.gyp:metrics',

+ '../components/components.gyp:metrics_net',

+ '../components/components.gyp:metrics_ui',

'../components/components.gyp:navigation_interception',

'../components/components.gyp:printing_common',

'../components/components.gyp:printing_browser',

@@ -301,6 +304,8 @@

'browser/aw_message_port_message_filter.cc',

'browser/aw_message_port_message_filter.h',

'browser/aw_message_port_service.h',

+ 'browser/aw_metrics_service_client.h',

+ 'browser/aw_metrics_service_client.cc',

'browser/aw_permission_manager.cc',

'browser/aw_permission_manager.h',

'browser/aw_pref_store.cc',

« no previous file with comments | « android_webview/DEPS ('k') | android_webview/browser/aw_browser_context.h » ('j') | android_webview/browser/aw_metrics_service_client.h » ('J')