WebView Metrics client implementation (Chromium part)

android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview;
 
 import android.content.Context;
 import android.content.SharedPreferences;
 
 import org.chromium.content.browser.ContentViewStatics;
 
 /**
  * Java side of the Browser Context: contains all the java side objects needed to host one
  * browing session (i.e. profile).
  * Note that due to running in single process mode, and limitations on renderer process only
  * being able to use a single browser context, currently there can only be one AwBrowserContext
  * instance, so at this point the class mostly exists for conceptual clarity.
  */
 public class AwBrowserContext {
     private static final String HTTP_AUTH_DATABASE_FILE = "http_auth.db";
 
     private final SharedPreferences mSharedPreferences;
+    private Context mApplicationContext;

[sgurun-gerrit only, 2015/12/11 00:06:45]

drop

[paulmiller, 2015/12/18 00:15:49]

fixed

 
     private AwGeolocationPermissions mGeolocationPermissions;
     private AwFormDatabase mFormDatabase;
     private HttpAuthDatabase mHttpAuthDatabase;
     private AwMessagePortService mMessagePortService;
+    private AwMetricsServiceClient mMetricsServiceClient;
 
     public AwBrowserContext(SharedPreferences sharedPreferences, Context applicationContext) {
         mSharedPreferences = sharedPreferences;
+        mApplicationContext = applicationContext;

[sgurun-gerrit only, 2015/12/11 00:06:45]

drop

[paulmiller, 2015/12/18 00:15:49]

fixed

+        getMetricsServiceClient();

[sgurun-gerrit only, 2015/12/11 00:06:45]

do a 
mMetricsServiceClient = new MetricsServiceClient(applicationContext)
here

[paulmiller, 2015/12/18 00:15:49]

fixed

     }
 
     public AwGeolocationPermissions getGeolocationPermissions() {
         if (mGeolocationPermissions == null) {
             mGeolocationPermissions = new AwGeolocationPermissions(mSharedPreferences);
         }
         return mGeolocationPermissions;
     }
 
     public AwFormDatabase getFormDatabase() {
@@ skipping 10 matching lines @@
         return mHttpAuthDatabase;
     }
 
     public AwMessagePortService getMessagePortService() {
         if (mMessagePortService == null) {
             mMessagePortService = new AwMessagePortService();
         }
         return mMessagePortService;
     }
 
+    public AwMetricsServiceClient getMetricsServiceClient() {
+        if (mMetricsServiceClient == null) {
+            mMetricsServiceClient = new AwMetricsServiceClient(mApplicationContext);
+        }
+        return mMetricsServiceClient;

[sgurun-gerrit only, 2015/12/11 00:06:45]

drop the if, simply return mMetricsServiceClient

[paulmiller, 2015/12/18 00:15:49]

fixed

+    }
+
     /**
      * @see android.webkit.WebView#pauseTimers()
      */
     public void pauseTimers() {
         ContentViewStatics.setWebKitSharedTimersSuspended(true);
     }
 
     /**
      * @see android.webkit.WebView#resumeTimers()
      */
     public void resumeTimers() {
         ContentViewStatics.setWebKitSharedTimersSuspended(false);
     }
 }