WebView Metrics client implementation (Chromium part)

android_webview/browser/aw_metrics_service_client.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ANDROID_WEBVIEW_BROWSER_AW_METRICS_SERVICE_CLIENT_IMPL_H_
+#define ANDROID_WEBVIEW_BROWSER_AW_METRICS_SERVICE_CLIENT_IMPL_H_
+
+#include "android_webview/browser/aw_metrics_service_client.h"
+
+#include <string>
+
+#include "base/lazy_instance.h"
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/metrics/metrics_service_client.h"
+
+class PrefService;
+
+namespace metrics {
+struct ClientInfo;
+class MetricsStateManager;
+}
+
+namespace net {
+class URLRequestContextGetter;
+}
+
+namespace android_webview {
+
+// This singleton manages metrics for an app using any number of WebViews.
+// Metrics is turned on and off by the homonymous Java class.
+class AwMetricsServiceClient : public metrics::MetricsServiceClient {

[sgurun-gerrit only, 2015/12/11 00:06:45]

in class doc mention about thread safety, which threads are the methods supposed
to be called from.

[paulmiller, 2015/12/18 00:15:49]

fixed

+  friend struct base::DefaultLazyInstanceTraits<AwMetricsServiceClient>;
+
+ public:
+  static AwMetricsServiceClient* GetInstance();
+  static void SetMetricsEnabled(bool enabled);

[sgurun-gerrit only, 2015/12/11 00:06:45]

make in non-static, let the caller call GetInstance()

[paulmiller, 2015/12/18 00:15:49]

fixed

+
+  void Initialize(PrefService* pref_service,
+                  net::URLRequestContextGetter* request_context);
+  void Finalize();
+
+  // metrics::MetricsServiceClient implementation
+  metrics::MetricsService* GetMetricsService() override;
+  void SetMetricsClientId(const std::string& client_id) override;
+  void OnRecordingDisabled() override;
+  bool IsOffTheRecordSessionActive() override;
+  int32_t GetProduct() override;
+  std::string GetApplicationLocale() override;
+  bool GetBrand(std::string* brand_code) override;
+  metrics::SystemProfileProto::Channel GetChannel() override;
+  std::string GetVersionString() override;
+  void OnLogUploadComplete() override;
+  void InitializeSystemProfileMetrics(
+      const base::Closure& done_callback) override;
+  void CollectFinalMetricsForLog(const base::Closure& done_callback) override;
+  scoped_ptr<metrics::MetricsLogUploader> CreateUploader(
+      const base::Callback<void(int)>& on_upload_complete) override;
+  base::TimeDelta GetStandardUploadInterval() override;
+
+ private:
+  AwMetricsServiceClient();
+  ~AwMetricsServiceClient() override;
+
+  // Callbacks for metrics::MetricsStateManager::Create
+  bool IsReportingEnabled();
+  void StoreClientInfo(const metrics::ClientInfo& client_info);
+  scoped_ptr<metrics::ClientInfo> LoadClientInfo();
+
+  static const int kUploadIntervalMinutes = 30;

[sgurun-gerrit only, 2015/12/11 00:06:45]

move to .cc file in an anonymous namespace

[paulmiller, 2015/12/18 00:15:49]

Is an anonymous namespace necessary? It's already private.

+
+  bool is_initialized_;
+  bool is_enabled_;
+  PrefService* pref_service_;
+  net::URLRequestContextGetter* request_context_;
+  scoped_ptr<metrics::MetricsStateManager> metrics_state_manager_;
+  scoped_ptr<metrics::MetricsService> metrics_service_;
+
+  DISALLOW_COPY_AND_ASSIGN(AwMetricsServiceClient);
+};
+
+}  // namespace android_webview
+
+#endif  // ANDROID_WEBVIEW_BROWSER_AW_METRICS_SERVICE_CLIENT_IMPL_H_