scripts/slave/recipe_modules/chromium/example.py - Issue 1474473004: Pass mb_mastername and mb_buildername as parameters to override the default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/example.py

Issue 1474473004: Pass mb_mastername and mb_buildername as parameters to override the default. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Pass mb_mastername and mb_buildername as parameters Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium/example.py

diff --git a/scripts/slave/recipe_modules/chromium/example.py b/scripts/slave/recipe_modules/chromium/example.py

index d016012461793798b50ae60179997c5a0e1875ea..07aaccbe94d236e80463271ff8ac71d6268f8b9a 100644

--- a/scripts/slave/recipe_modules/chromium/example.py

+++ b/scripts/slave/recipe_modules/chromium/example.py

@@ -9,14 +9,14 @@ DEPS = [

]

def RunSteps(api):

- mastername = api.properties.get('mastername')

- buildername = api.properties.get('buildername')

+ mastername = api.properties['mastername']

+ buildername = api.properties['buildername']

api.chromium_tests.configure_build(mastername, buildername)

update_step, master_dict, test_spec = \

api.chromium_tests.prepare_checkout(mastername, buildername)

#api.chromium_tests.compile(mastername, buildername, update_step, master_dict,

- # test_spec, out_dir='/tmp')

+ # test_spec, mastername, buildername)

api.chromium.compile(targets=['All'], out_dir='/tmp')

def GenTests(api):

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/api.py » ('j') | scripts/slave/recipe_modules/chromium_tests/api.py » ('J')