Pass mb_mastername and mb_buildername as parameters to override the default.

scripts/slave/recipe_modules/chromium_tests/api.py

Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index d628116a6caf786afa21c018d77b724286d89a12..aca70ff932d9bc52ae6cf26b118e851a7a4c1ba7 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -474,9 +474,13 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
       # be configured to match; we need to use the actual mastername
       # and buildername we're running on, because it may be configured
       # with different MB settings.
-      real_mastername = self.m.properties['mastername']
-      real_buildername = self.m.properties['buildername']
-      self.m.chromium.run_mb(real_mastername, real_buildername,
+      # However, recipes used by Findit may override the defaults to be able to
+      # exactly match a given continuous builder.
+      target_mastername = (self.m.properties.get('target_mastername') or

[Paweł Hajdan Jr., 2015/11/25 16:29:15]

Why not make these arguments of this method like I suggested?

[Dirk Pranke, 2015/11/25 17:26:34]

I replied to that in the other CL. I don't think it makes sense to do so because
findit can be calling multiple different recipes that would all have to be aware
of this. It seems better to have this logic in one place (or two, given the
change to analyze).

+                           self.m.properties['mastername'])
+      target_buildername = (self.m.properties.get('target_buildername') or
+                            self.m.properties['buildername'])
+      self.m.chromium.run_mb(target_mastername, target_buildername,
                              isolated_targets=isolated_targets,
                              name='generate_build_files%s' % name_suffix)