Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: scripts/slave/recipes/android_webview_aosp.py

Issue 1474473004: Pass mb_mastername and mb_buildername as parameters to override the default. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Pass mb_mastername and mb_buildername as parameters Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'android', 6 'android',
7 'chromium_android', 7 'chromium_android',
8 'filter', 8 'filter',
9 'json', 9 'json',
10 'path', 10 'path',
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 # build the parts of Chromium that are needed by the WebView. 67 # build the parts of Chromium that are needed by the WebView.
68 droid.gyp_webview_step() 68 droid.gyp_webview_step()
69 69
70 # This check is in place to detect incompatibly-licensed new code that's 70 # This check is in place to detect incompatibly-licensed new code that's
71 # checked into the main Chromium repository. 71 # checked into the main Chromium repository.
72 droid.all_incompatible_directories_check_step() 72 droid.all_incompatible_directories_check_step()
73 73
74 # Early out if we haven't changed any relevant code. 74 # Early out if we haven't changed any relevant code.
75 api.filter.does_patch_require_compile( 75 api.filter.does_patch_require_compile(
76 api.tryserver.get_files_affected_by_patch(), 76 api.tryserver.get_files_affected_by_patch(),
77 api.properties['mastername'],
78 api.properties['buildername'],
77 additional_compile_targets=WEBVIEW_EXES, 79 additional_compile_targets=WEBVIEW_EXES,
78 additional_names=['android_webview']) 80 additional_names=['android_webview'])
79 if api.tryserver.is_tryserver and not api.filter.compile_targets: 81 if api.tryserver.is_tryserver and not api.filter.compile_targets:
80 return 82 return
81 83
82 # If the Manifest has changed then we need to recompile everything. 84 # If the Manifest has changed then we need to recompile everything.
83 force_clobber = AOSP_MANIFEST_PATH in api.filter.paths 85 force_clobber = AOSP_MANIFEST_PATH in api.filter.paths
84 86
85 # TODO(android): use api.chromium.compile for this 87 # TODO(android): use api.chromium.compile for this
86 droid.compile_step( 88 droid.compile_step(
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 api.properties.tryserver() + 186 api.properties.tryserver() +
185 chrome_change 187 chrome_change
186 ) 188 )
187 189
188 yield ( 190 yield (
189 api.test('use_v8_patch_on_webview_trybot') + 191 api.test('use_v8_patch_on_webview_trybot') +
190 api.properties.tryserver() + 192 api.properties.tryserver() +
191 api.properties(patch_project='v8') + 193 api.properties(patch_project='v8') +
192 dependant_change 194 dependant_change
193 ) 195 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698