chrome/common/time_format_browsertest.cc - Issue 147443007: Add support for localized time strings with two units, eg. "2 hours 17 minutes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/time_format_browsertest.cc

Issue 147443007: Add support for localized time strings with two units, eg. "2 hours 17 minutes" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Tony's comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/time_format_browsertest.cc

diff --git a/chrome/common/time_format_browsertest.cc b/chrome/common/time_format_browsertest.cc

index 6b6fbf470dc74c36394e671744433d857d4183c9..0a110aacafc801533068b2ecfc7556dd8a620cac 100644

--- a/chrome/common/time_format_browsertest.cc

+++ b/chrome/common/time_format_browsertest.cc

@@ -35,6 +35,8 @@ IN_PROC_BROWSER_TEST_F(TimeFormatBrowserTest, DecimalPointNotDot) {

// http://crbug.com/60476

base::string16 one_min =

- ui::TimeFormat::TimeDurationShort(TimeDelta::FromMinutes(1));

+ ui::TimeFormat::Simple(ui::TimeFormat::FORMAT_DURATION,

+ ui::TimeFormat::LENGTH_SHORT,

+ TimeDelta::FromMinutes(1));

EXPECT_EQ(base::ASCIIToUTF16("1 min"), one_min);

}

« no previous file with comments | « chrome/browser/ui/webui/policy_ui.cc ('k') | ui/base/l10n/formatter.h » ('j') | no next file with comments »