chrome/browser/sync/profile_sync_service.cc - Issue 147443007: Add support for localized time strings with two units, eg. "2 hours 17 minutes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 147443007: Add support for localized time strings with two units, eg. "2 hours 17 minutes" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Tony's comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_item_model.cc ('k') | chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service.cc

diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc

index 09090fd6f86a0eacab78f2e17891c3e357e3ac9e..31322159ec7fd79b9a55f67ff7fb0dae2914eef0 100644

--- a/chrome/browser/sync/profile_sync_service.cc

+++ b/chrome/browser/sync/profile_sync_service.cc

@@ -1586,7 +1586,8 @@ base::string16 ProfileSyncService::GetLastSyncedTimeString() const {

if (last_synced < base::TimeDelta::FromMinutes(1))

return l10n_util::GetStringUTF16(IDS_SYNC_TIME_JUST_NOW);

- return ui::TimeFormat::TimeElapsed(last_synced);

+ return ui::TimeFormat::Simple(ui::TimeFormat::FORMAT_ELAPSED,

+ ui::TimeFormat::LENGTH_SHORT, last_synced);

}

void ProfileSyncService::UpdateSelectedTypesHistogram(

« no previous file with comments | « chrome/browser/download/download_item_model.cc ('k') | chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc » ('j') | no next file with comments »