ui/base/l10n/l10n_util_android.cc - Issue 147443007: Add support for localized time strings with two units, eg. "2 hours 17 minutes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/l10n/l10n_util_android.cc

Issue 147443007: Add support for localized time strings with two units, eg. "2 hours 17 minutes" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Bartosz' 2nd round of comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/l10n/l10n_util_android.cc

diff --git a/ui/base/l10n/l10n_util_android.cc b/ui/base/l10n/l10n_util_android.cc

index 50207e76c95566a796715a946b118563901e2efc..18715b1b73593dc95ddde909e9a8d55f6962a8f0 100644

--- a/ui/base/l10n/l10n_util_android.cc

+++ b/ui/base/l10n/l10n_util_android.cc

@@ -107,7 +107,8 @@ jstring GetDurationString(JNIEnv* env, jclass clazz, jlong timeInMillis) {

ScopedJavaLocalRef<jstring> jtime_remaining =

base::android::ConvertUTF16ToJavaString(

env,

- ui::TimeFormat::TimeRemaining(

+ ui::TimeFormat::Simple(

+ ui::TimeFormat::FORMAT_REMAINING, ui::TimeFormat::LENGTH_SHORT,

base::TimeDelta::FromMilliseconds(timeInMillis)));

return jtime_remaining.Release();

}

« ui/base/l10n/formatter.h ('K') | « ui/base/l10n/formatter.cc ('k') | ui/base/l10n/time_format.h » ('j') | ui/base/l10n/time_format.cc » ('J')