Issue 147443002: bypass_prodaccess fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147443002: bypass_prodaccess fix (Closed)

Created:
6 years, 11 months ago by Ryan Tseng

Modified:
6 years, 11 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, dtu

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

bypass_prodaccess fix It looked like the bypass_prodaccess flag wasn't passed in all the way to where it needed to be, causing it to be set to True by default at some point, which caused the prodaccess path to never happen. This change takes the flag and brings it all of the way. BUG=337972 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247049

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	third_party/gsutil/gslib/command_runner.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	third_party/gsutil/gsutil	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Tseng

Looks like the bypass_prodaccess change didn't bring the flag all the way into where it ...

6 years, 11 months ago (2014-01-24 23:22:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/147443002/1

6 years, 11 months ago (2014-01-25 01:07:32 UTC) #3

iannucci

6 years, 11 months ago (2014-01-25 17:07:32 UTC) #5

Message was sent while issue was closed.

On 2014/01/25 01:00:01, M-A Ruel wrote:
> (somewhat ruberstamp) lgtm

plastic stamp?

Expand Messages | Collapse Messages