Issue 14744002: changes to get Dartium building with MDV

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14744002: changes to get Dartium building with MDV (Closed)

Created:
7 years, 7 months ago by Jennifer Messerly

Modified:
7 years, 5 months ago

Reviewers:
blois

CC:
reviews+dom_dartlang.org, Emily Fortuna

Base URL:
http://src.chromium.org/multivm/trunk/webkit/Source/

Visibility:
Public.

More Reviews

Description

changes to get Dartium building with MDV this depends on https://codereview.chromium.org/14732003/

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	bindings/dart/gyp/dartium.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

FWIW, I'm not even sure I can check in to this branch :)

7 years, 7 months ago (2013-05-09 04:19:44 UTC) #2

blois

7 years, 7 months ago (2013-05-09 16:46:59 UTC) #3

lgtm

You *should* be able to check this in at the same time, and the bots will pick
it up within 5-10 minutes. So there will be some redness, but not for too long.

I say *should* because this relies on a process that runs somewhere as Anton,
that last time I checked in did not run (did the machine running it get turned
off while they are OOF?). So it had to be manually updated (Emily helps me with
that, I keep delaying getting my enlistment set up for it).

Expand Messages | Collapse Messages