Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: include/v8.h

Issue 1474353002: Remove easy to remove calls to Isolate::Current() from api.cc (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8-testing.h » ('j') | src/profiler/heap-snapshot-generator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 5ab8493852072a1a90fccb4725867af6e7afc8bf..8bfd0d24d240e347e1ccaa7020a9aaacb31331da 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3932,7 +3932,8 @@ class V8_EXPORT NumberObject : public Object {
*/
class V8_EXPORT BooleanObject : public Object {
public:
- static Local<Value> New(bool value);
+ static Local<Value> New(Isolate* isolate, bool value);
+ V8_DEPRECATE_SOON("Pass an isolate", static Local<Value> New(bool value));
bool ValueOf() const;
@@ -4583,7 +4584,7 @@ class V8_EXPORT ObjectTemplate : public Template {
static Local<ObjectTemplate> New(
Isolate* isolate,
Local<FunctionTemplate> constructor = Local<FunctionTemplate>());
- static V8_DEPRECATE_SOON("Use isolate version", Local<ObjectTemplate> New());
+ static V8_DEPRECATED("Use isolate version", Local<ObjectTemplate> New());
/** Creates a new instance of this template.*/
V8_DEPRECATE_SOON("Use maybe version", Local<Object> NewInstance());
@@ -4771,21 +4772,6 @@ class V8_EXPORT AccessorSignature : public Data {
};
-/**
- * A utility for determining the type of objects based on the template
- * they were constructed from.
- */
-class V8_EXPORT TypeSwitch : public Data {
- public:
- static Local<TypeSwitch> New(Local<FunctionTemplate> type);
- static Local<TypeSwitch> New(int argc, Local<FunctionTemplate> types[]);
- int match(Local<Value> value);
-
- private:
- TypeSwitch();
-};
-
-
// --- Extensions ---
class V8_EXPORT ExternalOneByteStringResourceImpl
« no previous file with comments | « no previous file | include/v8-testing.h » ('j') | src/profiler/heap-snapshot-generator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698