Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2662)

Issue 147433002: Remove unused methods from SkWindow. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove unused methods from SkWindow. I came to this while grepping for deprecated SkBitmap's eraseRGB() method. BUG=None TEST=SampleApp still links R=reed@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13184

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -68 lines) Patch
M include/views/SkWindow.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/views/SkWindow.cpp View 1 14 chunks +29 lines, -66 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Is this OK?
6 years, 11 months ago (2014-01-24 23:13:48 UTC) #1
reed1
lgtm
6 years, 11 months ago (2014-01-25 16:40:45 UTC) #2
tfarina
6 years, 11 months ago (2014-01-25 18:45:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698