Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1474303002: [heap] Remove live weak cells from weak cell list when finalizing incremental marking. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove live weak cells from weak cell list when finalizing incremental marking. BUG=chromium:548562 LOG=n Committed: https://crrev.com/6190c608c8f3ced0f00ff53965e115b78646cecd Cr-Commit-Position: refs/heads/master@{#32372}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/heap/incremental-marking.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Hannes Payer (out of office)
5 years ago (2015-11-27 10:43:12 UTC) #2
ulan
lgtm
5 years ago (2015-11-27 11:27:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474303002/20001
5 years ago (2015-11-27 11:28:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474303002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474303002/40001
5 years ago (2015-11-27 11:34:49 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-27 12:32:33 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6190c608c8f3ced0f00ff53965e115b78646cecd Cr-Commit-Position: refs/heads/master@{#32372}
5 years ago (2015-11-27 12:33:00 UTC) #12
Hannes Payer (out of office)
5 years ago (2015-12-01 13:26:30 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1481383004/ by hpayer@chromium.org.

The reason for reverting is: Still investigating bad canary..

Powered by Google App Engine
This is Rietveld 408576698