Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474283002: arc-bridge: Optimized scoped_ptr passing for ArcBridgeService (Closed)

Created:
5 years ago by khmel
Modified:
5 years ago
Reviewers:
hidehiko, khmel1, satorux1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc-bridge: Optimized scoped_ptr passing for ArcBridgeService BUG=558209 TEST=build and run Chrome Committed: https://crrev.com/8d22ae42800086d501dc4f653e646e6e286d9626 Cr-Commit-Position: refs/heads/master@{#361953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
khmel1
This is addressing last nit comment from previous CL. PTAL
5 years ago (2015-11-27 05:20:40 UTC) #4
satorux1
lgtm
5 years ago (2015-11-27 05:30:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474283002/1
5 years ago (2015-11-27 05:35:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 05:59:58 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-27 06:01:26 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8d22ae42800086d501dc4f653e646e6e286d9626
Cr-Commit-Position: refs/heads/master@{#361953}

Powered by Google App Engine
This is Rietveld 408576698