X87: [compiler] Always pass closure argument to with, catch and block context creation.

X87: [compiler] Always pass closure argument to with, catch and block context creation.

  port d3e5db04287b0b853e28552119e4177eb3bf10b9 (r32336)

  original commit message:
  Up until now we sometimes pass Smi 0 around as closure and expect the
  runtime to translate that appropriately. But we need to be careful in
  some places to not confuse the Smi 0 with a real closure. However, we
  could instead just pass the correct closure extracted from the native
  context.

  This addresses three long-standing TODOs in the JSTypedLowering pass.

  Drive-by-fix: Further unify error message reporting for ToObject (we had
  a special message in case of ToObject error in with context creation).

BUG=

Committed: https://crrev.com/e2128e3cf5a5c3109609298970f7cdfc7e3e0130
Cr-Commit-Position: refs/heads/master@{#32356}

[zhengxing.li, 2015-11-27 03:07:48]

zhengxing.li@intel.com changed reviewers:
+ bmeurer@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com

[Weiliang, 2015-11-27 04:12:59]

The CQ bit was checked by weiliang.lin@intel.com

[Weiliang, 2015-11-27 04:12:59]

lgtm

[commit-bot: I haz the power, 2015-11-27 04:13:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474243002/1

[commit-bot: I haz the power, 2015-11-27 04:31:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-27 04:31:49]

Description was changed from

==========
X87: [compiler] Always pass closure argument to with, catch and block context
creation.

  port d3e5db04287b0b853e28552119e4177eb3bf10b9 (r32336)

  original commit message:
  Up until now we sometimes pass Smi 0 around as closure and expect the
  runtime to translate that appropriately. But we need to be careful in
  some places to not confuse the Smi 0 with a real closure. However, we
  could instead just pass the correct closure extracted from the native
  context.

  This addresses three long-standing TODOs in the JSTypedLowering pass.

  Drive-by-fix: Further unify error message reporting for ToObject (we had
  a special message in case of ToObject error in with context creation).

BUG=
==========

to

==========
X87: [compiler] Always pass closure argument to with, catch and block context
creation.

  port d3e5db04287b0b853e28552119e4177eb3bf10b9 (r32336)

  original commit message:
  Up until now we sometimes pass Smi 0 around as closure and expect the
  runtime to translate that appropriately. But we need to be careful in
  some places to not confuse the Smi 0 with a real closure. However, we
  could instead just pass the correct closure extracted from the native
  context.

  This addresses three long-standing TODOs in the JSTypedLowering pass.

  Drive-by-fix: Further unify error message reporting for ToObject (we had
  a special message in case of ToObject error in with context creation).

BUG=

Committed: https://crrev.com/e2128e3cf5a5c3109609298970f7cdfc7e3e0130
Cr-Commit-Position: refs/heads/master@{#32356}
==========

[commit-bot: I haz the power, 2015-11-27 04:31:49]

Patchset 1 (id:??) landed as
https://crrev.com/e2128e3cf5a5c3109609298970f7cdfc7e3e0130
Cr-Commit-Position: refs/heads/master@{#32356}