third_party/WebKit/Source/core/css/CSSValue.h - Issue 1474213002: [PartitionAlloc] Annotate common Blink types for heap profiling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValue.h

Issue 1474213002: [PartitionAlloc] Annotate common Blink types for heap profiling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ctti

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSSelector.h ('K') | « third_party/WebKit/Source/core/css/CSSSelector.h ('k') | third_party/WebKit/Source/core/css/StylePropertySet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSValue.h b/third_party/WebKit/Source/core/css/CSSValue.h

index 5b2e09bbe368efa566e1103439d600478dd0afe8..3295eabdedcc5875eacc63083cc08b0ed2570058 100644

--- a/third_party/WebKit/Source/core/css/CSSValue.h

+++ b/third_party/WebKit/Source/core/css/CSSValue.h

@@ -32,8 +32,8 @@

namespace blink {

class CORE_EXPORT CSSValue : public RefCountedWillBeGarbageCollectedFinalized<CSSValue> {

-public:

#if ENABLE(OILPAN)

+public:

// Override operator new to allocate CSSValue subtype objects onto

// a dedicated heap.

GC_PLUGIN_IGNORE("crbug.com/443854")

@@ -47,6 +47,8 @@ public:

return Heap::allocateOnHeapIndex(state, size, isEager ? BlinkGC::EagerSweepHeapIndex : BlinkGC::CSSValueHeapIndex, GCInfoTrait<CSSValue>::index());

}

#else

+ USING_FAST_MALLOC_WITH_TYPE_NAME(CSSValue, "blink::CSSValue");

+public:

// Override RefCounted's deref() to ensure operator delete is called on

// the appropriate subclass type.

void deref()