Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1474203003: [heap] Cleanup mark bit usage. (Closed)

Created:
5 years ago by Hannes Payer (out of office)
Modified:
5 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cleanup mark bit usage. BUG= Committed: https://crrev.com/5874ac783ff9bc4bb4b2fda81f5077f06619f96c Cr-Commit-Position: refs/heads/master@{#32362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M src/heap/mark-compact.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Lippautz
lgtm
5 years ago (2015-11-27 09:11:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474203003/1
5 years ago (2015-11-27 09:11:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 09:14:49 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5874ac783ff9bc4bb4b2fda81f5077f06619f96c Cr-Commit-Position: refs/heads/master@{#32362}
5 years ago (2015-11-27 09:15:21 UTC) #7
Hannes Payer (out of office)
5 years ago (2015-12-01 13:28:31 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1490753003/ by hpayer@chromium.org.

The reason for reverting is: Still investigating bad canary..

Powered by Google App Engine
This is Rietveld 408576698