Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: ui/views/window/dialog_delegate.h

Issue 14742002: Render opaque border with no shadow for web contents modal dialogs under Views/Win32 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing USE_AURA check Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_delegate.h
diff --git a/ui/views/window/dialog_delegate.h b/ui/views/window/dialog_delegate.h
index ff7b031a8063b640d6b50dd872b1ca1631121cb0..1265e8ac5dbd87ffc44bd26288b3a73f060572eb 100644
--- a/ui/views/window/dialog_delegate.h
+++ b/ui/views/window/dialog_delegate.h
@@ -88,6 +88,14 @@ class VIEWS_EXPORT DialogDelegate : public WidgetDelegate {
// Create a frame view using the new dialog style.
static NonClientFrameView* CreateNewStyleFrameView(Widget* widget);
+ // The semi-transparent border and shadow of the new style frame view does not
+ // work on child windows under Views/Win32. This is a kludge to get a
+ // reasonable-looking opaque border for the dialog. Note that this does not
+ // support arrows.
+ //
+ // TODO(wittman): Remove once WinAura is in place.
+ static NonClientFrameView* CreateNewStyleFrameView(Widget* widget,
+ bool force_opaque_border);
// Called when the window has been closed.
virtual void OnClose() {}

Powered by Google App Engine
This is Rietveld 408576698