Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1474173003: Add iOS strings for contextual search in chrome://flags. (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
Reviewers:
droger, Olivier
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add iOS strings for contextual search in chrome://flags. BUG=551954 Committed: https://crrev.com/2067b8d8196804bf25ce1731dd1d53acf52e0767 Cr-Commit-Position: refs/heads/master@{#361974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
sdefresne
Please take a look.
5 years ago (2015-11-26 17:49:19 UTC) #2
Olivier
Don't we not need to also change about_flags.cc ?
5 years ago (2015-11-27 09:31:44 UTC) #3
sdefresne
5 years ago (2015-11-27 10:17:53 UTC) #5
sdefresne
No we do not introduce forks in //chrome for iOS. The file to be modified ...
5 years ago (2015-11-27 10:18:38 UTC) #6
droger
lgtm
5 years ago (2015-11-27 10:20:48 UTC) #7
Olivier
LGTM. (Don't we risk to see the string removed because it is unused upstream?)
5 years ago (2015-11-27 10:21:14 UTC) #8
sdefresne
On 2015/11/27 at 10:21:14, olivierrobin wrote: > LGTM. > (Don't we risk to see the ...
5 years ago (2015-11-27 10:22:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474173003/1
5 years ago (2015-11-27 10:22:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 10:27:14 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-27 10:28:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2067b8d8196804bf25ce1731dd1d53acf52e0767
Cr-Commit-Position: refs/heads/master@{#361974}

Powered by Google App Engine
This is Rietveld 408576698