Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1474103002: Re-reland "[Interpreter] Add CreateClosure to BytecodeGraphBuilder." (Closed)

Created:
5 years ago by oth
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy, mythria
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-reland "[Interpreter] Add CreateClosure to BytecodeGraphBuilder." Original issue's description: > [Interpreter] Add CreateClosure to BytecodeGraphBuilder. > > Adds code and tests to support CreateClosure bytecode when building > graphs. > > Committed: https://crrev.com/4cceb11b0929abcbc82bf0854554a9b66003335d > Cr-Commit-Position: refs/heads/master@{#32224} BUG=v8:4280 LOG=N Committed: https://crrev.com/c19a29f8c5abaa7164654709e53986da9f98807c Cr-Commit-Position: refs/heads/master@{#32342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -90 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +14 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +16 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 30 chunks +49 lines, -74 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
oth
Hopefully the last of this CL. Re-based version. Issue that required re-reland no longer exists ...
5 years ago (2015-11-26 13:57:37 UTC) #2
Benedikt Meurer
LGTM.
5 years ago (2015-11-26 14:01:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474103002/1
5 years ago (2015-11-26 14:06:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 14:33:09 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-26 14:34:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c19a29f8c5abaa7164654709e53986da9f98807c
Cr-Commit-Position: refs/heads/master@{#32342}

Powered by Google App Engine
This is Rietveld 408576698