Issue 14741007: Revert "Allow supporting 1 older PICTURE_VERSION."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14741007: Revert "Allow supporting 1 older PICTURE_VERSION." (Closed)

Created:
7 years, 7 months ago by scroggo

Modified:
7 years, 7 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert "Allow supporting 1 older PICTURE_VERSION." This reverts commit deb9d6990ef2d153230340d960d86b0966f261e1. That change was just to allow us to bump the PICTURE_VERSION without changing the SKPs to the new one. Since it is not entirely reliable, I am removing it. R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=9035

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -85 lines)			Patch
M	include/core/SkPicture.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	src/core/SkOrderedReadBuffer.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/core/SkOrderedReadBuffer.cpp	View	4 chunks	+35 lines, -74 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

Ravi, am I correct to assume that all the pictures we are using now have ...

7 years, 7 months ago (2013-05-06 18:18:30 UTC) #1

scroggo

7 years, 7 months ago (2013-05-07 14:45:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9035 (presubmit successful).

Expand Messages | Collapse Messages