Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html

Issue 14741004: NOT FOR REVIEW - Update comp-scrolling state at a well defined point in the pipeline. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added annotations describing how this patch will be split. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html
diff --git a/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html b/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html
index 8c5a37e8ad2b0a77a0bd9bec18a6110aeac8a369..21d36605f1e151d2462784bb54b1a888610c8f39 100644
--- a/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html
+++ b/LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html
@@ -53,12 +53,17 @@
</style>
<script src="resources/automatically-opt-into-composited-scrolling.js"></script>
<script>
+ // PATCH 1 (and below)
+ if (window.internals)
+ window.internals.settings.setAcceleratedCompositingForOverflowScrollEnabled(true);
+
function testPermutation(count, ordering, hasPositionedAncestor, containerIsPositioned)
{
if (!window.internals)
return;
var container = document.getElementById('container');
+ var containerOptedIn = didOptIn(container);
// Below, when we set webkitTransform to '', we want that to force an
// immediate, synchronous style recalculation. Querying the
@@ -79,17 +84,21 @@
// composited. To ensure that we perform the full style recalc, we need to
// change a style property so the style is dirty, and force the style to
// be cleaned with document.body.offsetTop (inside getStackingOrder()).
- window.internals.settings.setAcceleratedCompositingForOverflowScrollEnabled(false);
+ window.internals.setNeedsCompositedScrolling(container,
+ window.internals.FORCE_COMPOSITED_SCROLLING_OFF);
container.style.webkitTransform = '';
var oldStackingOrder = getStackingOrder(container);
- // force to promote.
- window.internals.settings.setAcceleratedCompositingForOverflowScrollEnabled(true);
+ window.internals.setNeedsCompositedScrolling(container,
+ window.internals.FORCE_COMPOSITED_SCROLLING_ON);
container.style.webkitTransform = 'translateZ(0px)';
var newStackingOrder = getStackingOrder(container);
+ window.internals.setNeedsCompositedScrolling(container,
+ window.internals.settings.DO_NOT_FORCE_COMPOSITED_SCROLLING);
+
var shouldOptIn = oldStackingOrder.length === newStackingOrder.length;
for (var i = 0; i < oldStackingOrder.length; ++i) {
if (oldStackingOrder[i] !== newStackingOrder[i]) {
@@ -99,7 +108,7 @@
}
container.style.webkitTransform = '';
- if (shouldOptIn !== didOptIn(container)) {
+ if (shouldOptIn !== containerOptedIn) {
if (shouldOptIn)
write("FAIL - should've automatically opted in but didn't " + count);
else

Powered by Google App Engine
This is Rietveld 408576698