NOT FOR REVIEW - Update comp-scrolling state at a well defined point in the pipeline.

Source/core/rendering/RenderLayerCompositor.cpp

 /*
  * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 200 matching lines @@
     , m_hasAcceleratedCompositing(true)
     , m_compositingTriggers(static_cast<ChromeClient::CompositingTriggerFlags>(ChromeClient::AllTriggers))
     , m_compositedLayerCount(0)
     , m_showDebugBorders(false)
     , m_showRepaintCounter(false)
     , m_reevaluateCompositingAfterLayout(false)
     , m_compositing(false)
     , m_compositingLayersNeedRebuild(false)
     , m_forceCompositingMode(false)
     , m_inPostLayoutUpdate(false)
+    , m_needsUpdateCompositingRequirementsState(false)
     , m_isTrackingRepaints(false)
     , m_rootLayerAttachment(RootLayerUnattached)
 #if !LOG_DISABLED
     , m_rootLayerUpdateCount(0)
     , m_obligateCompositedLayerCount(0)
     , m_secondaryCompositedLayerCount(0)
     , m_obligatoryBackingStoreBytes(0)
     , m_secondaryBackingStoreBytes(0)
 #endif
 {
@@ skipping 92 matching lines @@
         if (Page* page = this->page())
             page->chrome()->client()->scheduleCompositingLayerFlush();
     }
 }
 
 bool RenderLayerCompositor::hasAnyAdditionalCompositedLayers(const RenderLayer* rootLayer) const
 {
     return m_compositedLayerCount > (rootLayer->isComposited() ? 1 : 0);
 }
 
+void RenderLayerCompositor::updateCompositingRequirementsState(RenderLayer* updateRoot)

[hartmanng, 2013/05/01 20:25:07]

I feel like updateDescendantDependentFlags should be called in here, don't we
need it?

[Ian Vollick, 2013/05/02 03:24:50]

Done.

+{
+    TRACE_EVENT0("blink-rendering", "RenderLayerCompositor::updateCompositingRequirementsState\n");
+
+    if (!m_needsUpdateCompositingRequirementsState)
+        return;
+
+    if (!updateRoot) {
+        updateRoot = rootRenderLayer();
+        updateRoot->updateHasOutOfFlowPositionedDescendant();

[hartmanng, 2013/05/01 20:25:07]

why do we only update this inside the if block?

[Ian Vollick, 2013/05/02 03:24:50]

That call is recursive, so I only want to call it once in the first call to
updateCompositingRequirementsState.

+    }
+
+    updateRoot->updateNeedsCompositedScrolling();
+
+    // In this function we update state that determines whether layers are
+    // stacking containers. We may therefore not use this concept here. Instead,
+    // we'll iterate through the tree topologically. 
+    for (RenderLayer* child = updateRoot->firstChild(); child; child = child->nextSibling()) {
+#ifndef NDEBUG
+        fprintf(stderr, "vollick: RenderLayerCompositor::updateCompositingRequirementsState\n");
+#endif
+        updateCompositingRequirementsState(child);
+    }
+
+    m_needsUpdateCompositingRequirementsState = false;
+}
+
 void RenderLayerCompositor::updateCompositingLayers(CompositingUpdateType updateType, RenderLayer* updateRoot)
 {
     // Avoid updating the layers with old values. Compositing layers will be updated after the layout is finished.
     if (m_renderView->needsLayout())
         return;
 
     if (m_forceCompositingMode && !m_compositing)
         enableCompositingMode(true);
 
     if (!m_reevaluateCompositingAfterLayout && !m_compositing)
@@ skipping 2415 matching lines @@
     info.addMember(m_layerForScrollCorner, "layerForScrollCorner");
 #if ENABLE(RUBBER_BANDING)
     info.addMember(m_layerForOverhangAreas, "layerForOverhangAreas");
     info.addMember(m_contentShadowLayer, "contentShadowLayer");
     info.addMember(m_layerForTopOverhangArea, "layerForTopOverhangArea");
     info.addMember(m_layerForBottomOverhangArea, "layerForBottomOverhangArea");
 #endif
 }
 
 } // namespace WebCore