Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1474073002: Reland of base: Make shared memory backed by Mach primitives by default. (Closed)

Created:
5 years ago by Sami
Modified:
5 years ago
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of base: Make shared memory backed by Mach primitives by default. (patchset #1 id:1 of https://codereview.chromium.org/1472313002/ ) Reason for revert: Relanding. Looks like the failures may have been unrelated after all. Original issue's description: > Revert of base: Make shared memory backed by Mach primitives by default. (patchset #3 id:40001 of https://codereview.chromium.org/1453383002/ ) > > Reason for revert: > Speculative revert: 3 mac perf bots started timing out in random tests around the time this patch landed. I'll keep an eye on the waterfall and reland if things don't improve. > > See https://code.google.com/p/chromium/issues/detail?id=561416 for logs. > > Original issue's description: > > base: Make shared memory backed by Mach primitives by default. > > > > The type of shared memory used is controlled by an A/B experiment. If the > > experiment isn't present, use Mach primitives. > > > > BUG=466437 > > > > Committed: https://crrev.com/8b8e4212cef52b2cf924c27bb7c49e375306acb3 > > Cr-Commit-Position: refs/heads/master@{#361249} > > TBR=mark@chromium.org,avi@chromium.org,erikchen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=466437 > > Committed: https://crrev.com/3e6b742e634e657d87c3267c2a8f9158c297f801 > Cr-Commit-Position: refs/heads/master@{#361630} TBR=mark@chromium.org,avi@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466437 Committed: https://crrev.com/8e53d1be210193655b682ab381c3377700705067 Cr-Commit-Position: refs/heads/master@{#361869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -27 lines) Patch
M base/memory/shared_memory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 3 chunks +13 lines, -19 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/loader/resource_buffer.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sami
Created Reland of base: Make shared memory backed by Mach primitives by default.
5 years ago (2015-11-26 11:41:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474073002/1
5 years ago (2015-11-26 11:41:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 11:42:42 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-26 11:43:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e53d1be210193655b682ab381c3377700705067
Cr-Commit-Position: refs/heads/master@{#361869}

Powered by Google App Engine
This is Rietveld 408576698