Source/core/accessibility/AccessibilitySpinButton.h - Issue 14740025: Simplify and add caching for accessible bounding box calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AccessibilitySpinButton.h

Issue 14740025: Simplify and add caching for accessible bounding box calculation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update comment Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AccessibilitySpinButton.h

diff --git a/Source/core/accessibility/AccessibilitySpinButton.h b/Source/core/accessibility/AccessibilitySpinButton.h

index 89eda699e3c1623a0ee0fb77b14a0ad695cf5684..d01f20a4f30db58651359bf8846d187b7cd7f97f 100644

--- a/Source/core/accessibility/AccessibilitySpinButton.h

+++ b/Source/core/accessibility/AccessibilitySpinButton.h

@@ -51,7 +51,7 @@ private:

virtual bool isSpinButton() const { return true; }

virtual bool isNativeSpinButton() const { return true; }

virtual void addChildren();

- virtual LayoutRect elementRect() const;

+ virtual LayoutRect elementRect();

SpinButtonElement* m_spinButtonElement;

};

@@ -71,7 +71,7 @@ private:

virtual bool press() const;

virtual AccessibilityRole roleValue() const { return ButtonRole; }

virtual bool isSpinButtonPart() const { return true; }

- virtual LayoutRect elementRect() const;

+ virtual LayoutRect elementRect();

};

inline AccessibilitySpinButton* toAccessibilitySpinButton(AccessibilityObject* object)