Source/core/accessibility/AccessibilityMenuListPopup.h - Issue 14740025: Simplify and add caching for accessible bounding box calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AccessibilityMenuListPopup.h

Issue 14740025: Simplify and add caching for accessible bounding box calculation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update comment Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AccessibilityMenuListPopup.h

diff --git a/Source/core/accessibility/AccessibilityMenuListPopup.h b/Source/core/accessibility/AccessibilityMenuListPopup.h

index 45cab92a093e9b5d52a70ecccd5ce76c2ebb8002..898f968c07250d600cbc50bf8d0824f4d33cff9a 100644

--- a/Source/core/accessibility/AccessibilityMenuListPopup.h

+++ b/Source/core/accessibility/AccessibilityMenuListPopup.h

@@ -50,7 +50,7 @@ private:

virtual bool isMenuListPopup() const { return true; }

- virtual LayoutRect elementRect() const { return LayoutRect(); }

+ virtual LayoutRect elementRect() { return LayoutRect(); }

virtual AccessibilityRole roleValue() const { return MenuListPopupRole; }

virtual bool isVisible() const;