Source/core/accessibility/AccessibilityNodeObject.cpp - Issue 14740025: Simplify and add caching for accessible bounding box calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AccessibilityNodeObject.cpp

Issue 14740025: Simplify and add caching for accessible bounding box calculation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-landing with null check fix Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AccessibilityNodeObject.cpp

diff --git a/Source/core/accessibility/AccessibilityNodeObject.cpp b/Source/core/accessibility/AccessibilityNodeObject.cpp

index 81efb83599b36b339a85a11e2434de48cb426472..b4e81226c12c4d81df31649b764341781bc4600f 100644

--- a/Source/core/accessibility/AccessibilityNodeObject.cpp

+++ b/Source/core/accessibility/AccessibilityNodeObject.cpp

@@ -1294,7 +1294,7 @@ String AccessibilityNodeObject::helpText() const

return String();

}

-LayoutRect AccessibilityNodeObject::boundingBoxRect() const

+LayoutRect AccessibilityNodeObject::elementRect() const

{

// AccessibilityNodeObjects have no mechanism yet to return a size or position.

// For now, let's return the position of the ancestor that does have a position,

@@ -1314,11 +1314,6 @@ LayoutRect AccessibilityNodeObject::boundingBoxRect() const

return boundingBox;

}

-LayoutRect AccessibilityNodeObject::elementRect() const

- return boundingBoxRect();

AccessibilityObject* AccessibilityNodeObject::parentObject() const

{

if (!node())