Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: Source/core/accessibility/AccessibilityMenuListOption.cpp

Issue 14740025: Simplify and add caching for accessible bounding box calculation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 bool AccessibilityMenuListOption::canSetSelectedAttribute() const 86 bool AccessibilityMenuListOption::canSetSelectedAttribute() const
87 { 87 {
88 return isEnabled(); 88 return isEnabled();
89 } 89 }
90 90
91 bool AccessibilityMenuListOption::computeAccessibilityIsIgnored() const 91 bool AccessibilityMenuListOption::computeAccessibilityIsIgnored() const
92 { 92 {
93 return accessibilityIsIgnoredByDefault(); 93 return accessibilityIsIgnoredByDefault();
94 } 94 }
95 95
96 LayoutRect AccessibilityMenuListOption::elementRect() const 96 LayoutRect AccessibilityMenuListOption::elementRect()
97 { 97 {
98 AccessibilityObject* parent = parentObject(); 98 AccessibilityObject* parent = parentObject();
99 ASSERT(parent->isMenuListPopup()); 99 ASSERT(parent->isMenuListPopup());
100 100
101 AccessibilityObject* grandparent = parent->parentObject(); 101 AccessibilityObject* grandparent = parent->parentObject();
102 ASSERT(grandparent->isMenuList()); 102 ASSERT(grandparent->isMenuList());
103 103
104 return grandparent->elementRect(); 104 return grandparent->elementRect();
105 } 105 }
106 106
107 String AccessibilityMenuListOption::stringValue() const 107 String AccessibilityMenuListOption::stringValue() const
108 { 108 {
109 return static_cast<HTMLOptionElement*>(m_element.get())->text(); 109 return static_cast<HTMLOptionElement*>(m_element.get())->text();
110 } 110 }
111 111
112 } // namespace WebCore 112 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698