Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 14740016: Revert r197164: Avoid crashing the browser on truncated reads [...] (Closed)

Created:
7 years, 7 months ago by pasko-google - do not use
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ilya Sherman, gavinp+disk_chromium.org, MAD, jar (doing other things), gavinp
Visibility:
Public.

Description

Revert r197164: Avoid crashing the browser on truncated reads [...] After a long discussion it was decided that the backend is the only proper place for this kind of correctness checks. All backends should do that. BUG=236384 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198425

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -37 lines) Patch
M net/http/http_cache_transaction.cc View 2 chunks +2 lines, -24 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pasko-google - do not use
7 years, 7 months ago (2013-05-02 16:57:45 UTC) #1
rvargas (doing something else)
lgtm
7 years, 7 months ago (2013-05-02 17:41:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@google.com/14740016/1
7 years, 7 months ago (2013-05-02 17:45:57 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=967
7 years, 7 months ago (2013-05-02 17:58:57 UTC) #4
pasko-google - do not use
Rebased, adding Jim as reviewer.
7 years, 7 months ago (2013-05-03 09:22:59 UTC) #5
Ilya Sherman
LGTM. Feel free to TBR reverts, and preferably to use drover to land them.
7 years, 7 months ago (2013-05-03 09:38:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@google.com/14740016/8001
7 years, 7 months ago (2013-05-03 10:11:26 UTC) #7
pasko-google - do not use
On 2013/05/03 09:38:22, Ilya Sherman wrote: > LGTM. Feel free to TBR reverts, and preferably ...
7 years, 7 months ago (2013-05-03 10:12:43 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110466
7 years, 7 months ago (2013-05-03 12:39:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@google.com/14740016/8001
7 years, 7 months ago (2013-05-03 14:11:45 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110574
7 years, 7 months ago (2013-05-03 16:57:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@google.com/14740016/8001
7 years, 7 months ago (2013-05-06 10:13:44 UTC) #12
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 12:24:11 UTC) #13
Message was sent while issue was closed.
Change committed as 198425

Powered by Google App Engine
This is Rietveld 408576698