Enable shelf gestures in immersive mode

ash/shelf/shelf_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_layout_manager.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "ash/ash_switches.h"
@@ skipping 429 matching lines @@
   gesture_drag_auto_hide_state_ =
       gesture_drag_auto_hide_state_ == SHELF_AUTO_HIDE_SHOWN ?
       SHELF_AUTO_HIDE_HIDDEN : SHELF_AUTO_HIDE_SHOWN;
   if (shelf_)
     shelf_->Deactivate();
   shelf_->status_area_widget()->Deactivate();
   if (gesture_drag_auto_hide_state_ == SHELF_AUTO_HIDE_HIDDEN &&
       auto_hide_behavior_ != SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS) {
     gesture_drag_status_ = GESTURE_DRAG_NONE;
     SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);
+    aura::Window* active = wm::GetActiveWindow();

[Harry McCleave, 2013/05/02 20:36:32]

Would this not be better served as an if/else pairing (the current flow of
SetAuto...(ALWAYS); SetAutoHide...(NEVER) in the
active/fullscreen/MinimalChromeKey case seems cumbersome.

[rharrison, 2013/05/16 17:31:04]

Done.

+    if (active &&
+        wm::IsWindowFullscreen(active) &&
+        active->GetProperty(kFullscreenUsesMinimalChromeKey))

[sadrul, 2013/05/02 20:43:58]

I am not familiar with this magical key. But it would be good to
SetAutoHideBehavior just once, instead of setting it to ALWAYS (449), and
setting it back to NEVER (454).

[rharrison, 2013/05/16 17:31:04]

Done.

+      SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);

[pkotwicz, 2013/05/06 20:50:37]

Drive by:
- You should probably use RootWindowController::GetFullscreenWindow() For
instance, in immersive fullscreen, the bookmark bubble could be active, but we
are theoretically still fullscreen.

[rharrison, 2013/05/16 17:31:04]

Done.

   } else if (gesture_drag_auto_hide_state_ == SHELF_AUTO_HIDE_SHOWN &&
              auto_hide_behavior_ != SHELF_AUTO_HIDE_BEHAVIOR_NEVER) {
     gesture_drag_status_ = GESTURE_DRAG_NONE;
     SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);
   } else {
     gesture_drag_status_ = GESTURE_DRAG_COMPLETE_IN_PROGRESS;
     UpdateVisibilityState();
     gesture_drag_status_ = GESTURE_DRAG_NONE;
   }
   LayoutShelf();
@@ skipping 491 matching lines @@
       return gfx::Insets(0, distance, 0, 0);
     case SHELF_ALIGNMENT_TOP:
       return gfx::Insets(0, 0, distance, 0);
   }
   NOTREACHED();
   return gfx::Insets();
 }
 
 }  // namespace internal
 }  // namespace ash