runtime/vm/flow_graph_allocator.cc - Issue 14740005: Initial support for polymorphic inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 14740005: Initial support for polymorphic inlining. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Incorporated review comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_allocator.cc

diff --git a/runtime/vm/flow_graph_allocator.cc b/runtime/vm/flow_graph_allocator.cc

index 5125f971ce1b8ad6f57ce4dd3ad3ed4afd7f0ab7..1ac20cad0629be9276ce3e70a54ca0bd50762906 100644

--- a/runtime/vm/flow_graph_allocator.cc

+++ b/runtime/vm/flow_graph_allocator.cc

@@ -2187,7 +2187,10 @@ bool FlowGraphAllocator::UnallocatedIsSorted() {

for (intptr_t i = unallocated_.length() - 1; i >= 1; i--) {

LiveRange* a = unallocated_[i];

LiveRange* b = unallocated_[i - 1];

- if (!ShouldBeAllocatedBefore(a, b)) return false;

+ if (!ShouldBeAllocatedBefore(a, b)) {

+ UNREACHABLE();

+ return false;

+ }

}

return true;

}

« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/flow_graph_builder.h » ('j') | no next file with comments »