Restore original WebView SurfaceId after showing interstitial.

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "cc/surfaces/surface.h"
 #include "cc/surfaces/surface_factory.h"
@@ skipping 77 matching lines @@
   // TODO(lazyboy): We shouldn't be showing interstitial pages in guests in the
   // first place: http://crbug.com/273089.
   //
   // |guest_| is NULL during test.
   if ((guest_ && guest_->is_in_destruction()) || !host_->is_hidden())
     return;
   // Make sure the size of this view matches the size of the WebContentsView.
   // The two sizes may fall out of sync if we switch RenderWidgetHostViews,
   // resize, and then switch page, as is the case with interstitial pages.
   // NOTE: |guest_| is NULL in unit tests.
-  if (guest_)
+  if (guest_) {
     SetSize(guest_->web_contents()->GetViewBounds().size());
+    if (!surface_id_.is_null()) {
+      guest_->SetChildFrameSurface(surface_id_, current_surface_size_,
+                                   current_surface_scale_factor_,
+                                   surface_sequence_);

[kenrb, 2015/11/25 21:44:02]

I wonder if it might be safer to destroy any existing Surface here. The
SurfaceManager gets rid of Surfaces that are not being used anymore, because all
of their dependencies have been satisfied. The purpose of passing the
SurfaceSequence to SetChildFrameSurface is actually because
OnSwapCompositorFrame creates a temporary dependency on the new Surface,
protecting it from the SurfaceManager's garbage collection. Then the embedding
renderer satisfies that dependency after it has created its own (see
BrowserPluginGuest::OnSatisfySequence and OnRequireSequence). When the Surface
gets replaced in the embedder with the interstitial's Surface, I would worry
that the original might get destroyed because it no longer has any destruction
dependencies and it becomes unreachable in the surface tree.

You might want to check with jbauman@ on this, in any case.

[wjmaclean, 2015/11/25 21:50:17]

Acknowledged.

+    }
+  }
   host_->WasShown(ui::LatencyInfo());
 }
 
 void RenderWidgetHostViewGuest::Hide() {
   // |guest_| is NULL during test.
   if ((guest_ && guest_->is_in_destruction()) || host_->is_hidden())
     return;
   host_->WasHidden();
 }
 
@@ skipping 138 matching lines @@
 
   if (!surface_factory_) {
     cc::SurfaceManager* manager = GetSurfaceManager();
     surface_factory_ = make_scoped_ptr(new cc::SurfaceFactory(manager, this));
   }
 
   if (surface_id_.is_null()) {
     surface_id_ = id_allocator_->GenerateId();
     surface_factory_->Create(surface_id_);
 
-    cc::SurfaceSequence sequence = cc::SurfaceSequence(
-        id_allocator_->id_namespace(), next_surface_sequence_++);
+    surface_sequence_ = cc::SurfaceSequence(
+        id_allocator_->id_namespace(), surface_sequence_.sequence + 1);
     // The renderer process will satisfy this dependency when it creates a
     // SurfaceLayer.
     cc::SurfaceManager* manager = GetSurfaceManager();
-    manager->GetSurfaceForId(surface_id_)->AddDestructionDependency(sequence);
+    manager->GetSurfaceForId(surface_id_)
+        ->AddDestructionDependency(surface_sequence_);
     guest_->SetChildFrameSurface(surface_id_, frame_size, scale_factor,
-                                 sequence);
+                                 surface_sequence_);
   }
 
   cc::SurfaceFactory::DrawCallback ack_callback = base::Bind(
       &RenderWidgetHostViewChildFrame::SurfaceDrawn,
       RenderWidgetHostViewChildFrame::AsWeakPtr(), output_surface_id);
   ack_pending_count_++;
   // If this value grows very large, something is going wrong.
   DCHECK(ack_pending_count_ < 1000);
   surface_factory_->SubmitCompositorFrame(surface_id_, frame.Pass(),
                                           ack_callback);
@@ skipping 441 matching lines @@
     if (gesture_event.type == blink::WebInputEvent::GestureScrollUpdate &&
         gesture_event.data.scrollUpdate.inertial) {
       return;
     }
     host_->ForwardGestureEvent(gesture_event);
     return;
   }
 }
 
 }  // namespace content