Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1473883002: ipc: Minor fixes to AttachmentBrokerPrivilegedMac. (Closed)

Created:
5 years ago by erikchen
Modified:
5 years ago
Reviewers:
Tom Sepez, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Minor fixes to AttachmentBrokerPrivilegedMac. Two small changes: - Better cleanup when a process has gone away, but extractors or precursors are still present. - Remove an unused method. BUG=561105 Committed: https://crrev.com/28f0a585535c129e0303281ee4a58f6c07384c48 Cr-Commit-Position: refs/heads/master@{#362057}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Check for nullptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -29 lines) Patch
M ipc/attachment_broker_privileged.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/attachment_broker_privileged_mac.h View 1 3 chunks +5 lines, -7 lines 0 comments Download
M ipc/attachment_broker_privileged_mac.cc View 1 2 8 chunks +66 lines, -22 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
erikchen
tsepez: Please review ipc/ isherman: Please review histograms.xml
5 years ago (2015-11-25 01:59:13 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473883002/20001
5 years ago (2015-11-25 02:05:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/145792)
5 years ago (2015-11-25 03:13:19 UTC) #6
Ilya Sherman
histograms.xml lgtm
5 years ago (2015-11-25 05:12:36 UTC) #7
Tom Sepez
LGTM
5 years ago (2015-11-25 17:51:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473883002/20001
5 years ago (2015-11-25 20:56:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473883002/40001
5 years ago (2015-11-25 22:37:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years ago (2015-11-26 00:42:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473883002/40001
5 years ago (2015-11-26 00:48:36 UTC) #17
commit-bot: I haz the power
Exceeded global retry quota
5 years ago (2015-11-26 02:52:07 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473883002/40001
5 years ago (2015-11-28 20:34:19 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-28 22:03:40 UTC) #22
commit-bot: I haz the power
5 years ago (2015-11-28 22:04:38 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/28f0a585535c129e0303281ee4a58f6c07384c48
Cr-Commit-Position: refs/heads/master@{#362057}

Powered by Google App Engine
This is Rietveld 408576698