third_party/WebKit/LayoutTests/accessibility/display-none-change.html - Issue 1473833002: Fix bugs in accessible name calculation code exposed by Bryan Garaventa's test files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/accessibility/display-none-change.html

Issue 1473833002: Fix bugs in accessible name calculation code exposed by Bryan Garaventa's test files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dumb_mistake

Patch Set: Fix android test expectation Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/description-calc-inputs.html ('k') | third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/accessibility/display-none-change.html

diff --git a/third_party/WebKit/LayoutTests/accessibility/display-none-change.html b/third_party/WebKit/LayoutTests/accessibility/display-none-change.html

index 9697088a2536c65a8d5aae17a201b3bcd929b308..8b247767ef3010abcd3c5beb6621ee4f107eb76e 100644

--- a/third_party/WebKit/LayoutTests/accessibility/display-none-change.html

+++ b/third_party/WebKit/LayoutTests/accessibility/display-none-change.html

@@ -13,7 +13,7 @@ test(function(t){

// Ensure that it's valid.

var axLabel = axButton.nameElementAtIndex(0);

assert_equals(axLabel.isValid, true);

- assert_equals(axLabel.name, 'AriaLabel');

+ assert_equals(axLabel.role, 'AXRole: AXLabel');

// Now un-hide the label.

var label = document.getElementById('label');

@@ -36,7 +36,7 @@ test(function(t){

assert_equals(axLabel.isValid, false);

assert_equals(axLabel2.isValid, false);

assert_equals(axLabel3.isValid, true);

- assert_equals(axLabel3.name, 'AriaLabel');

+ assert_equals(axLabel3.role, 'AXRole: AXLabel');

assert_equals(axLabel.isEqual(axLabel3), false);

assert_equals(axLabel2.isEqual(axLabel3), false);

}, "Accessibility objects for display:none elements");