third_party/WebKit/LayoutTests/accessibility/name-calc-visibility.html - Issue 1473833002: Fix bugs in accessible name calculation code exposed by Bryan Garaventa's test files.

Side by Side Diff: third_party/WebKit/LayoutTests/accessibility/name-calc-visibility.html

Issue 1473833002: Fix bugs in accessible name calculation code exposed by Bryan Garaventa's test files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dumb_mistake

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/img-alt-tag-only-whitespace-expected.txt ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4

	5 <style>

	6 .hideAllContainers .container {

	7 display: none;

	8 }

	9 </style>

	10

	11 <div id="link1" class="container" tabIndex=0 role="link">

	12 <p>1</p>

	13 <table>

	14 <tr><td>2</td></tr>

	15 <tr><td style="visibility: hidden">3</td></tr>

	16 <tr><td style="display:none">4</td></tr>

	17 <tr style="visibility: hidden"><td>5</td></tr>

	18 <tr style="display: none"><td>6</td></tr>

	19 </table>

	20 <p>7</p>

	21 </div>

	22

	23 <script>

	24 test(function(t) {

	25 var axLink1 = accessibilityController.accessibleElementById("link1");

	26 assert_equals(axLink1.name, "1 2 7");

	27 }, "Visibility: hidden and display: none inside ARIA link");

	28 </script>

	29

	30 <div class="container">

	31 <input id="input2" aria-labelledby="label2">

	32

	33 <div id="label2">

	34 <p>1</p>

	35 <table>

	36 <tr><td>2</td></tr>

	37 <tr><td style="visibility: hidden">3</td></tr>

	38 <tr><td style="display:none">4</td></tr>

	39 <tr style="visibility: hidden"><td>5</td></tr>

	40 <tr style="display: none"><td>6</td></tr>

	41 </table>

	42 <p>7</p>

	43 </div>

	44 </div>

	45

	46 <script>

	47 test(function(t) {

	48 var axInput2 = accessibilityController.accessibleElementById("input2");

	49 assert_equals(axInput2.name, "1 2 7");

	50 }, "Visibility: hidden and display: none inside aria-labelledby label subtree");

	51 </script>

	52

	53 <div class="container">

	54 <input id="input3" aria-labelledby="3a 3b 3c 3d 3e 3f 3g">

	55

	56 <p id="3a">1</p>

	57 <table>

	58 <tr><td id="3b">2</td></tr>

	59 <tr><td id="3c" style="visibility: hidden">3</td></tr>

	60 <tr><td id="3d" style="display:none">4</td></tr>

	61 <tr id="3e" style="visibility: hidden"><td>5</td></tr>

	62 <tr id="3f" style="display: none"><td>6</td></tr>

	63 </table>

	64 <p id="3g">7</p>

	65 </div>

	66

	67 <script>

	68 test(function(t) {

	69 var axInput3 = accessibilityController.accessibleElementById("input3");

	70 assert_equals(axInput3.name, "1 2 3 4 6 7");

	71 }, "Visibility: hidden and display: none referenced directly by aria-labelledby" );

	72 </script>

	73

	74 <div class="container">

	75 <input id="input4" aria-labelledby="label4">

	76

	77 <div style="display: none">

	78 <div id="label4">

	79 <p>1</p>

	80 <table>

	81 <tr><td>2</td></tr>

	82 <tr><td style="visibility: hidden">3</td></tr>

	83 <tr><td style="display:none">4</td></tr>

	84 <tr style="visibility: hidden"><td>5</td></tr>

	85 <tr style="display: none"><td>6</td></tr>

	86 </table>

	87 <p>7</p>

	88 </div>

	89 </div>

	90 </div>

	91

	92 <script>

	93 test(function(t) {

	94 var axInput4 = accessibilityController.accessibleElementById("input4");

	95 assert_equals(axInput4.name, " 1 2 7 ");
	aboxhall 2015/11/30 19:20:19 Why does this one alone get the extra leading/trai Why does this one alone get the extra leading/trailing whitespace? dmazzoni 2015/12/01 08:52:39 Because all of the static text in this example com Show quoted text On 2015/11/30 19:20:19, aboxhall wrote: > Why does this one alone get the extra leading/trailing whitespace? Because all of the static text in this example comes from inside a display: none block, it doesn't really get rendered on-screen, so we can't apply any logic about what whitespace gets collapsed and what doesn't. To be safe we end up with leading and trailing whitespace in this case. It doesn't bother me that much, especially just for a corner case.
	96 }, "Visibility: hidden and display: none inside aria-labelledby label subtree");
	aboxhall 2015/11/30 19:20:19 This description is the same as the one on line 50 This description is the same as the one on line 50, and I think it's incomplete in this case. Some reference to the parent `display: none` div? (BTW, I found these sentences pretty hard to parse given it seems to read "... none inside aria-labelledby subtree"; putting back-ticks or similar around the CSS might make it a little easier.) dmazzoni 2015/12/01 08:52:39 Done. Show quoted text On 2015/11/30 19:20:19, aboxhall wrote: > This description is the same as the one on line 50, and I think it's incomplete > in this case. Some reference to the parent `display: none` div? > > (BTW, I found these sentences pretty hard to parse given it seems to read "... > none inside aria-labelledby subtree"; putting back-ticks or similar around the > CSS might make it a little easier.) Done.
	97 </script>

	98

	99 <script>

	100 if (window.testRunner)

	101 document.body.className = "hideAllContainers";

	102 </script>

OLD	NEW