Fix bugs in accessible name calculation code exposed by Bryan Garaventa's test files.

third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 1603 matching lines @@
 bool AXNodeObject::nameFromLabelElement() const
 {
     // This unfortunately duplicates a bit of logic from textAlternative and nativeTextAlternative,
     // but it's necessary because nameFromLabelElement needs to be called from
     // computeAccessibilityIsIgnored, which isn't allowed to call axObjectCache->getOrCreate.
 
     if (!node() && !layoutObject())
         return false;
 
     // Step 2A from: http://www.w3.org/TR/accname-aam-1.1
-    if (layoutObject()
-        && layoutObject()->style()->visibility() != VISIBLE
-        && !equalIgnoringCase(getAttribute(aria_hiddenAttr), "false")) {
+    if (isHiddenForTextAlternativeCalculation())
         return false;
-    }
 
     // Step 2B from: http://www.w3.org/TR/accname-aam-1.1
     WillBeHeapVector<RawPtrWillBeMember<Element>> elements;
     ariaLabelledbyElementVector(elements);
     if (elements.size() > 0)
         return false;
 
     // Step 2C from: http://www.w3.org/TR/accname-aam-1.1
     const AtomicString& ariaLabel = getAttribute(aria_labelAttr);
     if (!ariaLabel.isEmpty())
@@ skipping 814 matching lines @@
 
 String AXNodeObject::description(AXNameFrom nameFrom, AXDescriptionFrom& descriptionFrom, AXObjectVector* descriptionObjects) const
 {
     AXRelatedObjectVector relatedObjects;
     String result = description(nameFrom, descriptionFrom, nullptr, &relatedObjects);
     if (descriptionObjects) {
         descriptionObjects->clear();
         for (size_t i = 0; i < relatedObjects.size(); i++)
             descriptionObjects->append(relatedObjects[i]->object);
     }
-    return result;
+
+    return collapseWhitespace(result);
 }
 
 // Based on http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#accessible-name-and-description-calculation
 String AXNodeObject::description(AXNameFrom nameFrom, AXDescriptionFrom& descriptionFrom, DescriptionSources* descriptionSources, AXRelatedObjectVector* relatedObjects) const
 {
     // If descriptionSources is non-null, relatedObjects is used in filling it in, so it must be non-null as well.
     if (descriptionSources)
         ASSERT(relatedObjects);
 
     if (!node())
@@ skipping 210 matching lines @@
     return placeholder;
 }
 
 DEFINE_TRACE(AXNodeObject)
 {
     visitor->trace(m_node);
     AXObject::trace(visitor);
 }
 
 } // namespace blin