third_party/WebKit/LayoutTests/accessibility/description-calc-inputs.html - Issue 1473833002: Fix bugs in accessible name calculation code exposed by Bryan Garaventa's test files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/accessibility/description-calc-inputs.html

Issue 1473833002: Fix bugs in accessible name calculation code exposed by Bryan Garaventa's test files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dumb_mistake

Patch Set: Fix android test expectation Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/accessibility/android_granularity_movement_browsertest.cc ('k') | third_party/WebKit/LayoutTests/accessibility/display-none-change.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4	4

5 <style>	5 <style>

6 .hideAllContainers .container {	6 .hideAllContainers .container {

7 display: none;	7 display: none;

8 }	8 }

9 </style>	9 </style>

10	10

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 <script>	101 <script>

102 test(function(t) {	102 test(function(t) {

103 var axTextInput7 = accessibilityController.accessibleElementById("text7");	103 var axTextInput7 = accessibilityController.accessibleElementById("text7");

104 assert_equals(axTextInput7.name, "Label");	104 assert_equals(axTextInput7.name, "Label");

105 assert_equals(axTextInput7.nameFrom, "attribute");	105 assert_equals(axTextInput7.nameFrom, "attribute");

106 assert_equals(axTextInput7.description, "Placeholder");	106 assert_equals(axTextInput7.description, "Placeholder");

107 assert_equals(axTextInput7.descriptionFrom, "placeholder");	107 assert_equals(axTextInput7.descriptionFrom, "placeholder");

108 }, "placeholder overrides title as the accessible description.");	108 }, "placeholder overrides title as the accessible description.");

109 </script>	109 </script>

110	110

	111 <div class="container">

	112 <input id="text8" type="text" aria-describedby="describedby8">

	113 <p id="describedby8">

	114 Described

	115 <br>

	116 By

	117 </p>

	118 </div>

	119

	120 <script>

	121 test(function(t) {

	122 var axTextInput8 = accessibilityController.accessibleElementById("text8");

	123 assert_equals(axTextInput8.name, "");

	124 assert_equals(axTextInput8.nameFrom, "");

	125 assert_equals(axTextInput8.description, "Described By");

	126 assert_equals(axTextInput8.descriptionFrom, "relatedElement");

	127 }, "aria-describedby does not include newlines.");

	128 </script>

	129

111 <script>	130 <script>

112 if (window.testRunner)	131 if (window.testRunner)

113 document.body.className = "hideAllContainers";	132 document.body.className = "hideAllContainers";

114 </script>	133 </script>

OLD	NEW