Add a GetRegistryPath method to BrowserDistribution.

Add a GetRegistryPath method to BrowserDistribution.

BrowserDistribution::GetRegistryPath returns the registry path in which
registry keys for the distribution should reside.

This method should be used instead of concatenating PRODUCT_STRING_PATH
or BrowserDistribution::GetInstallSubDir to L"Software" everywhere in
the code base.

Known call sites to fix are listed in the bug.

BUG=561711
Committed: https://crrev.com/c23229d22ed1b421fd8395bf1d14b78fbd07209b
Cr-Commit-Position: refs/heads/master@{#361927}

[fdoray, 2015-11-25 22:15:43]

fdoray@chromium.org changed reviewers:
+ grt@chromium.org

[fdoray, 2015-11-25 22:15:43]

Greg, can you review this? Thanks.

[grt (UTC plus 2), 2015-11-26 15:33:34]

lgtm. could you check with sergeyu@ to see if it's intentional that
NativeMessagingHosts doesn't differentiate SxS from regular Chrome? that's one
place, at least, where Chromium, Google Chrome, and Google Chrome SxS all seem
to read from the same location. :-(

https://codereview.chromium.org/1473813003/diff/1/chrome/installer/util/brows...
File chrome/installer/util/browser_distribution.h (right):

https://codereview.chromium.org/1473813003/diff/1/chrome/installer/util/brows...
chrome/installer/util/browser_distribution.h:134: // Returns the registry path
under which registry keys for this distribution
How about documenting the contract for this key a bit more explicitly. What do
you think of:

  // Returns the path "Software\<PRODUCT>". This subkey of HKEY_CURRENT_USER can
  // be used to save and restore state. With the exception of data that is used
  // by third parties (e.g., a subkey that specifies the location of a native
  // messaging host's manifest), state stored in this key is removed during
  // uninstall when the user chooses to also delete their browsing data.

[fdoray, 2015-11-26 18:54:03]

all done.

sent an email to sergeyu@ about the NativeMessagingHosts key.

committing.

https://codereview.chromium.org/1473813003/diff/1/chrome/installer/util/brows...
File chrome/installer/util/browser_distribution.h (right):

https://codereview.chromium.org/1473813003/diff/1/chrome/installer/util/brows...
chrome/installer/util/browser_distribution.h:134: // Returns the registry path
under which registry keys for this distribution
On 2015/11/26 15:33:34, grt wrote:
> How about documenting the contract for this key a bit more explicitly. What do
> you think of:
> 
>   // Returns the path "Software\<PRODUCT>". This subkey of HKEY_CURRENT_USER
can
>   // be used to save and restore state. With the exception of data that is
used
>   // by third parties (e.g., a subkey that specifies the location of a native
>   // messaging host's manifest), state stored in this key is removed during
>   // uninstall when the user chooses to also delete their browsing data.

Done.

[fdoray, 2015-11-26 18:54:06]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2015-11-26 18:54:06]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1473813003/#ps20001
(title: "improve method comment.")

[commit-bot: I haz the power, 2015-11-26 18:54:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473813003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473813003/20001

[commit-bot: I haz the power, 2015-11-26 21:16:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-26 21:17:34]

Description was changed from

==========
Add a GetRegistryPath method to BrowserDistribution.

BrowserDistribution::GetRegistryPath returns the registry path in which
registry keys for the distribution should reside.

This method should be used instead of concatenating PRODUCT_STRING_PATH
or BrowserDistribution::GetInstallSubDir to L"Software" everywhere in
the code base.

Known call sites to fix are listed in the bug.

BUG=561711
==========

to

==========
Add a GetRegistryPath method to BrowserDistribution.

BrowserDistribution::GetRegistryPath returns the registry path in which
registry keys for the distribution should reside.

This method should be used instead of concatenating PRODUCT_STRING_PATH
or BrowserDistribution::GetInstallSubDir to L"Software" everywhere in
the code base.

Known call sites to fix are listed in the bug.

BUG=561711

Committed: https://crrev.com/c23229d22ed1b421fd8395bf1d14b78fbd07209b
Cr-Commit-Position: refs/heads/master@{#361927}
==========

[commit-bot: I haz the power, 2015-11-26 21:17:36]

Patchset 2 (id:??) landed as
https://crrev.com/c23229d22ed1b421fd8395bf1d14b78fbd07209b
Cr-Commit-Position: refs/heads/master@{#361927}

[gab, 2015-11-27 16:11:12]

On 2015/11/26 21:17:36, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/c23229d22ed1b421fd8395bf1d14b78fbd07209b
> Cr-Commit-Position: refs/heads/master@{#361927}

Woot, drive-by lgtm and cheers, thanks for addressing this :-)!