Issue 14738009: Ensure that soft-deopts don't count against opt_count

Issue 14738009: Ensure that soft-deopts don't count against opt_count (Closed)

Created:
7 years, 7 months ago by danno

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure that soft-deopts don't count against opt_count This makes sure that Crankshaft doesn't disable optimization to early on hot functions that still contain unexecuted code without type information. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14658

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Patch Set 3 : Implement x64 and ARM, review feedback #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+256 lines, -166 lines)			Patch
M	src/arm/builtins-arm.cc	View	1 2	1 chunk	+5 lines, -0 lines	1 comment	Download
M	src/arm/deoptimizer-arm.cc	View	1 2	4 chunks	+11 lines, -6 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	1 2	3 chunks	+5 lines, -13 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	7 chunks	+30 lines, -12 lines	0 comments	Download
M	src/builtins.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/deoptimizer.h	View		2 chunks	+51 lines, -36 lines	0 comments	Download
M	src/deoptimizer.cc	View	1 2	11 chunks	+30 lines, -28 lines	0 comments	Download
M	src/disassembler.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	src/ia32/builtins-ia32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View		3 chunks	+10 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 2	2 chunks	+5 lines, -13 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	8 chunks	+31 lines, -14 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+9 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/builtins-x64.cc	View	1 2	1 chunk	+5 lines, -0 lines	1 comment	Download
M	src/x64/deoptimizer-x64.cc	View	1 2	3 chunks	+11 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 2	3 chunks	+5 lines, -14 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	7 chunks	+30 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Only minor comments. Go ahead with the platform ports. https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode984 src/ia32/lithium-codegen-ia32.cc:984: ...

7 years, 7 months ago (2013-05-14 11:01:57 UTC) #1

danno

Platform ports done, tests run. Please take another look. https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/14738009/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode984 src/ia32/lithium-codegen-ia32.cc:984: ...

7 years, 7 months ago (2013-05-14 11:29:09 UTC) #2

Jakob Kummerow

LGTM with comments. https://codereview.chromium.org/14738009/diff/14001/src/arm/builtins-arm.cc File src/arm/builtins-arm.cc (right): https://codereview.chromium.org/14738009/diff/14001/src/arm/builtins-arm.cc#newcode1344 src/arm/builtins-arm.cc:1344: Generate_NotifyDeoptimizedHelper(masm, Deoptimizer::LAZY); same here https://codereview.chromium.org/14738009/diff/14001/src/x64/builtins-x64.cc File ...

7 years, 7 months ago (2013-05-14 11:39:05 UTC) #3

danno

7 years, 7 months ago (2013-05-14 11:45:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r14658 (presubmit successful).

Expand Messages | Collapse Messages