Clarify naming for fast-path in setLogicalWidthForTextRun

Clarify naming for fast-path in setLogicalWidthForTextRun

Rename the canUseSimpleFontCodePath flag to canUseCachedWordMeasurements
in LayoutBlockFlowLine::setLogicalWidthForTextRun to better describe how
it is used. Add comment to rename the canUseSimpleFontCodePath method in
LayoutText.h once the simple code path has been removed.

BUG=404597
R=leviw@chromium.org

Committed: https://crrev.com/b4f0e9f9ca28367c8b952894b5ef34fa70e956d4
Cr-Commit-Position: refs/heads/master@{#361523}

[eae, 2015-11-24 22:09:51]

Description was changed from

==========
Clarify naming for fast-path in setLogicalWidthForTextRun

BUG=
==========

to

==========
Clarify naming for fast-path in setLogicalWidthForTextRun

Rename the canUseSimpleFontCodePath flag to canUseCachedWordMeasurements
in LayoutBlockFlowLine::setLogicalWidthForTextRun to better describe how
it is used. Add comment to rename the canUseSimpleFontCodePath method in
LayoutText.h once the simple code path has been removed.

BUG=404597
R=leviw@chromium.org
==========

[eae, 2015-11-24 22:09:51]

eae@chromium.org changed reviewers:
+ leviw@chromium.org

[eae, 2015-11-24 22:10:14]

Adding TODO

[leviw_travelin_and_unemployed, 2015-11-24 22:28:29]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-11-24 22:28:30]

lgtm

[commit-bot: I haz the power, 2015-11-24 22:29:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473773002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473773002/1

[commit-bot: I haz the power, 2015-11-25 02:21:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-25 02:22:33]

Patchset 1 (id:??) landed as
https://crrev.com/b4f0e9f9ca28367c8b952894b5ef34fa70e956d4
Cr-Commit-Position: refs/heads/master@{#361523}

[drott, 2015-11-25 12:46:23]

drott@chromium.org changed reviewers:
+ drott@chromium.org

[drott, 2015-11-25 12:46:24]

When working on the removal CL...

https://codereview.chromium.org/1473773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1473773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:450: bool
canUseCachedWordMeasurements = layoutText->canUseSimpleFontCodePath() &&
!font.fontDescription().featureSettings();
I am trying to understand what this line actually means and what we should be
doing with it.

The canUseSimpleCodePath implementation means: either 8bit or not complex only
character ranges...

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Is that really intended? Or can we not use the word cache in more situations?

[eae, 2015-11-25 16:01:14]

On 2015/11/25 12:46:24, drott wrote:
> When working on the removal CL...
> 
>
https://codereview.chromium.org/1473773002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):
> 
>
https://codereview.chromium.org/1473773002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:450: bool
> canUseCachedWordMeasurements = layoutText->canUseSimpleFontCodePath() &&
> !font.fontDescription().featureSettings();
> I am trying to understand what this line actually means and what we should be
> doing with it.
> 
> The canUseSimpleCodePath implementation means: either 8bit or not complex only
> character ranges...
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Is that really intended? Or can we not use the word cache in more situations?

No, thats why I added a TODO to change the implementation (and rename it) so
that it only triggers in cases where we cannot use the word cache.