Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1473763003: X87: Reshuffle registers in JSConstructStub to avoid trashing costructor and new.target on fast pat… (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reshuffle registers in JSConstructStub to avoid trashing costructor and new.target on fast path (so we don't need to push/pop them). port 0ef5ad5ab97657f7e3393be7512fef883b205c87 (r32219) original commit message: This CL also fixed register usages in MacroAssembler::Allocate() broken by 2fc2cb99 (r32144). BUG= Committed: https://crrev.com/4a514c77adddb59f2fa9e576bfb22177322fce8d Cr-Commit-Position: refs/heads/master@{#32245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/x87/builtins-x87.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years ago (2015-11-25 04:36:21 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-25 05:33:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473763003/1
5 years ago (2015-11-25 05:33:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 06:05:24 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 06:05:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a514c77adddb59f2fa9e576bfb22177322fce8d
Cr-Commit-Position: refs/heads/master@{#32245}

Powered by Google App Engine
This is Rietveld 408576698