Chromium Code Reviews| Index: components/crash/content/browser/crash_dump_manager_android.h |
| diff --git a/components/crash/content/browser/crash_dump_manager_android.h b/components/crash/content/browser/crash_dump_manager_android.h |
| index e3f2391efe775851903cdfa88b6617599c646109..bad3fb32fadf7c673629aedecbdb209472468f48 100644 |
| --- a/components/crash/content/browser/crash_dump_manager_android.h |
| +++ b/components/crash/content/browser/crash_dump_manager_android.h |
| @@ -7,13 +7,16 @@ |
| #include <map> |
| +#include "base/android/application_status_listener.h" |
| #include "base/files/file.h" |
| #include "base/files/file_path.h" |
| +#include "base/process/kill.h" |
| #include "base/process/process.h" |
| #include "base/synchronization/lock.h" |
| #include "content/public/browser/browser_child_process_observer.h" |
| #include "content/public/browser/notification_observer.h" |
| #include "content/public/browser/notification_registrar.h" |
| +#include "content/public/common/process_type.h" |
| namespace content { |
| class RenderProcessHost; |
| @@ -48,8 +51,23 @@ class CrashDumpManager : public content::BrowserChildProcessObserver, |
| private: |
| typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath; |
| + // This enum is used to back a UMA histogram, and must be treated as |
| + // append-only. |
| + enum ExitStatus { |
| + EMPTY_MINIDUMP_WHILE_RUNNING = 0, |
| + EMPTY_MINIDUMP_WHILE_PAUSED = 1, |
| + EMPTY_MINIDUMP_WHILE_BACKGROUND = 2, |
| + VALID_MINIDUMP_WHILE_RUNNING = 3, |
| + VALID_MINIDUMP_WHILE_PAUSED = 4, |
| + VALID_MINIDUMP_WHILE_BACKGROUND = 5, |
| + COUNT = 6 |
|
cpu_(ooo_6.6-7.5)
2015/11/30 23:54:54
that is some strange enum style, for one you can r
Peter Wen
2015/12/01 18:40:41
Done.
|
| + }; |
| + |
| static void ProcessMinidump(const base::FilePath& minidump_path, |
| - base::ProcessHandle pid); |
| + base::ProcessHandle pid, |
| + content::ProcessType process_type, |
| + base::TerminationStatus exit_status, |
| + base::android::ApplicationState app_state); |
| // content::BrowserChildProcessObserver implementation: |
| void BrowserChildProcessHostDisconnected( |
| @@ -64,7 +82,11 @@ class CrashDumpManager : public content::BrowserChildProcessObserver, |
| const content::NotificationDetails& details) override; |
| // Called on child process exit (including crash). |
| - void OnChildExit(int child_process_id, base::ProcessHandle pid); |
| + void OnChildExit(int child_process_id, |
| + base::ProcessHandle pid, |
| + content::ProcessType process_type, |
| + base::TerminationStatus exit_status, |
| + base::android::ApplicationState app_state); |
| content::NotificationRegistrar notification_registrar_; |